Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(frame-benchmarking-cli): Pass heap_pages param to WasmExecutor #2075

Merged
merged 2 commits into from
Oct 29, 2023

Conversation

ukint-vs
Copy link
Contributor

In paritytech/substrate#13740 the use of the heap-pages param inside the frame-benchmarking-cli has been removed.
This results in running out of memory and this PR fixes the heap allocation strategy for benchmarks wasm executor.

@cla-bot-2021
Copy link

cla-bot-2021 bot commented Oct 29, 2023

User @ukint-vs, please sign the CLA here.

@paritytech-cicd-pr
Copy link

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: cargo-clippy
Logs: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/4117352

Copy link
Member

@ggwpez ggwpez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me, but please @koute take a look as well.

@ggwpez ggwpez added the T1-FRAME This PR/Issue is related to core FRAME, the framework. label Oct 29, 2023
@bkchr bkchr enabled auto-merge (squash) October 29, 2023 12:19
@bkchr bkchr merged commit 8ce16ee into paritytech:master Oct 29, 2023
115 of 116 checks passed
bgallois pushed a commit to duniter/duniter-polkadot-sdk that referenced this pull request Mar 25, 2024
…aritytech#2075)

In paritytech/substrate#13740 the use of the
`heap-pages` param inside the `frame-benchmarking-cli` has been removed.
This results in running out of memory and this PR fixes the heap
allocation strategy for benchmarks wasm executor.
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Mar 26, 2024
…ch#2075)

* fixed off-by-one when confirming rewards in messages pallet

* Update modules/messages/src/inbound_lane.rs
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Mar 27, 2024
…ch#2075)

* fixed off-by-one when confirming rewards in messages pallet

* Update modules/messages/src/inbound_lane.rs
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 8, 2024
…ch#2075)

* fixed off-by-one when confirming rewards in messages pallet

* Update modules/messages/src/inbound_lane.rs
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 8, 2024
…ch#2075)

* fixed off-by-one when confirming rewards in messages pallet

* Update modules/messages/src/inbound_lane.rs
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 8, 2024
…ch#2075)

* fixed off-by-one when confirming rewards in messages pallet

* Update modules/messages/src/inbound_lane.rs
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 8, 2024
…ch#2075)

* fixed off-by-one when confirming rewards in messages pallet

* Update modules/messages/src/inbound_lane.rs
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 8, 2024
…ch#2075)

* fixed off-by-one when confirming rewards in messages pallet

* Update modules/messages/src/inbound_lane.rs
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 9, 2024
…ch#2075)

* fixed off-by-one when confirming rewards in messages pallet

* Update modules/messages/src/inbound_lane.rs
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 9, 2024
…ch#2075)

* fixed off-by-one when confirming rewards in messages pallet

* Update modules/messages/src/inbound_lane.rs
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 9, 2024
…ch#2075)

* fixed off-by-one when confirming rewards in messages pallet

* Update modules/messages/src/inbound_lane.rs
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 9, 2024
…ch#2075)

* fixed off-by-one when confirming rewards in messages pallet

* Update modules/messages/src/inbound_lane.rs
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 9, 2024
…ch#2075)

* fixed off-by-one when confirming rewards in messages pallet

* Update modules/messages/src/inbound_lane.rs
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 9, 2024
…ch#2075)

* fixed off-by-one when confirming rewards in messages pallet

* Update modules/messages/src/inbound_lane.rs
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 10, 2024
…ch#2075)

* fixed off-by-one when confirming rewards in messages pallet

* Update modules/messages/src/inbound_lane.rs
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 10, 2024
…ch#2075)

* fixed off-by-one when confirming rewards in messages pallet

* Update modules/messages/src/inbound_lane.rs
bkchr pushed a commit that referenced this pull request Apr 10, 2024
* fixed off-by-one when confirming rewards in messages pallet

* Update modules/messages/src/inbound_lane.rs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T1-FRAME This PR/Issue is related to core FRAME, the framework.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants