Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch All construct_runtimes to New Syntax #2979

Merged
merged 21 commits into from
Jan 22, 2024
Merged

Switch All construct_runtimes to New Syntax #2979

merged 21 commits into from
Jan 22, 2024

Conversation

joepetrowski
Copy link
Contributor

Clean up all the old syntax.

@joepetrowski joepetrowski added R0-silent Changes should not be mentioned in any release notes T14-system_parachains This PR/Issue is related to system parachains. labels Jan 18, 2024
bkchr
bkchr approved these changes Jan 18, 2024
View reviewed changes
Copy link
Member

@bkchr bkchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!!

@joepetrowski
Copy link
Contributor Author

Actually, I can just do the Polkadot and Substrate ones too in this branch.

@joepetrowski joepetrowski requested a review from a team as a code owner January 18, 2024 09:57
@joepetrowski joepetrowski requested review from a team January 18, 2024 10:10
@joepetrowski joepetrowski requested a review from a team January 18, 2024 10:10
@joepetrowski joepetrowski changed the title Switch All Cumulus construct_runtimes to New Syntax Switch All construct_runtimes to New Syntax Jan 18, 2024
@joepetrowski
Copy link
Contributor Author

bot fmt

@command-bot
Copy link

command-bot bot commented Jan 18, 2024 •
edited
Loading

@joepetrowski https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/4952118 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh". Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 7-3960744c-0acd-4dae-a460-8dd8441e7fab to cancel this command or bot cancel to cancel all commands in this pull request.

@command-bot
Copy link

command-bot bot commented Jan 18, 2024

@joepetrowski Command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh" has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/4952118 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/4952118/artifacts/download.

gupnik
gupnik approved these changes Jan 18, 2024
View reviewed changes
Copy link
Contributor

@gupnik gupnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed, might need to update the UI Test outputs.

@gupnik
Copy link
Contributor

gupnik commented Jan 19, 2024

bot update-ui

@command-bot
Copy link

command-bot bot commented Jan 19, 2024 •
edited
Loading

@gupnik https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/4963196 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/update-ui/update-ui.sh". Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 8-430e7d00-a6df-487e-a45e-7528899284c5 to cancel this command or bot cancel to cancel all commands in this pull request.

@command-bot
Copy link

command-bot bot commented Jan 19, 2024

@gupnik Command "$PIPELINE_SCRIPTS_DIR/commands/update-ui/update-ui.sh" has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/4963196 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/4963196/artifacts/download.

@mordamax
Copy link
Contributor

bot update-ui

@command-bot
Copy link

command-bot bot commented Jan 19, 2024 •
edited
Loading

@mordamax https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/4970635 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/update-ui/update-ui.sh". Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 1-b6ca34d3-3c02-41a8-a174-5aa3648a19cb to cancel this command or bot cancel to cancel all commands in this pull request.

@command-bot
Copy link

command-bot bot commented Jan 19, 2024

@mordamax Command "$PIPELINE_SCRIPTS_DIR/commands/update-ui/update-ui.sh" has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/4970635 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/4970635/artifacts/download.

@joepetrowski
Copy link
Contributor Author

bot update-ui

@command-bot
Copy link

command-bot bot commented Jan 19, 2024 •
edited
Loading

@joepetrowski https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/4977096 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/update-ui/update-ui.sh". Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 6-10f8cbe7-7c3b-4818-93b5-e2184b74ecc6 to cancel this command or bot cancel to cancel all commands in this pull request.

@command-bot
Copy link

command-bot bot commented Jan 19, 2024

@joepetrowski Command "$PIPELINE_SCRIPTS_DIR/commands/update-ui/update-ui.sh" has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/4977096 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/4977096/artifacts/download.

@mordamax
Copy link
Contributor

bot update-ui

@command-bot
Copy link

command-bot bot commented Jan 19, 2024 •
edited
Loading

@mordamax https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/4978832 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/update-ui/update-ui.sh". Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 1-6f292ed2-ab07-4fb9-838f-6bfe4cffec1f to cancel this command or bot cancel to cancel all commands in this pull request.

@mordamax
Copy link
Contributor

bot cancel

@mordamax
Copy link
Contributor

bot update-ui

@command-bot
Copy link

command-bot bot commented Jan 19, 2024 •
edited
Loading

@mordamax https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/4978833 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/update-ui/update-ui.sh". Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 2-c7832cf0-fc63-41d6-8e71-237f6f3589c0 to cancel this command or bot cancel to cancel all commands in this pull request.

@command-bot
Copy link

command-bot bot commented Jan 19, 2024

@mordamax Command "$PIPELINE_SCRIPTS_DIR/commands/update-ui/update-ui.sh" has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/4978832 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/4978832/artifacts/download.

@command-bot
Copy link

command-bot bot commented Jan 19, 2024

@mordamax Command "$PIPELINE_SCRIPTS_DIR/commands/update-ui/update-ui.sh" has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/4978833 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/4978833/artifacts/download.

@joepetrowski joepetrowski added this pull request to the merge queue Jan 22, 2024
Merged via the queue into master with commit 757ae37 Jan 22, 2024
124 checks passed
@joepetrowski joepetrowski deleted the joe-use-new-construct-runtime-system-paras branch January 22, 2024 07:57
@github-actions github-actions bot mentioned this pull request Mar 13, 2024
Closed
bgallois pushed a commit to duniter/duniter-polkadot-sdk that referenced this pull request Mar 25, 2024
@joepetrowski @codekitz
@gupnik @mordamax
Switch All construct_runtimes to New Syntax (paritytech#2979)
53c113c 
Clean up all the old syntax.

---------

Co-authored-by: command-bot <>
Co-authored-by: gupnik <nikhilgupta.iitk@gmail.com>
Co-authored-by: Nikhil Gupta <17176722+gupnik@users.noreply.github.com>
Co-authored-by: Maksym H <1177472+mordamax@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsidorenko jsidorenko jsidorenko approved these changes

@bkchr bkchr bkchr approved these changes

@bkontur bkontur bkontur approved these changes

@seadanda seadanda seadanda approved these changes

@gupnik gupnik gupnik approved these changes

@acatangiu acatangiu acatangiu approved these changes

@athei athei Awaiting requested review from athei

@cheme cheme Awaiting requested review from cheme cheme is a code owner

Assignees
No one assigned
Labels
R0-silent Changes should not be mentioned in any release notes T14-system_parachains This PR/Issue is related to system parachains.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@joepetrowski @gupnik @mordamax @jsidorenko @bkchr @bkontur @seadanda @acatangiu @codekitz