Experimental RuntimeDebug -> Debug substitutions.

[hirschenberger]

see #3005

My local results are:

╭───┬────────────────────────────────────────────────────────────────────────────────╮
│ 0 │ fast_runtime_binary.rs.compact.compressed.wasm:   NewSize: 1493084 (+1425)     │
│ 1 │ rococo_runtime.compact.compressed.wasm:           NewSize: 1493143 (+793)      │
│ 2 │ westend_runtime.compact.compressed.wasm:          NewSize: 1626913 (+1973)     │
╰───┴────────────────────────────────────────────────────────────────────────────────╯

compiled with cargo build --profile=production

EDIT: I removed the kitchensink as it was a relic from previous runs

• Replace all derives RuntimeDebug and RuntimeDebugNoBound to Debug
• Remove all use expressions for RuntimeDebug and RuntimeDebugNoBound
• Deprecate RuntimeDebug and RuntimeDebugNoBound
• Remove all RuntimeDebug and RuntimeDebugNoBound references on docs and doctests
• Rerun the before-and-after size comparison of wasm runtimes

[ggwpez]

I think we can also deprecate the RuntimeDebug derive macro then or?

[bkchr]

I think we can also deprecate the RuntimeDebug derive macro then or?

Yes.

[ggwpez]

@hirschenberger I think we can go ahead with this?
Its also fine if you dont want to do the deprecation, we can do it in another MR.

[hirschenberger]

@hirschenberger I think we can go ahead with this? Its also fine if you dont want to do the deprecation, we can do it in another MR.

Ok, so I'll continue.

The next steps would be to deprecate RuntimeDebug and fix all resulting deprecation warnings, correct?

[bkchr]

The next steps would be to deprecate RuntimeDebug and fix all resulting deprecation warnings, correct?

Yes!

[bkchr]

@hirschenberger are you interested on continue working on this?

[hirschenberger]

@hirschenberger are you interested on continue working on this?

Yes, just got a new notebook which makes development on that issue much snappier.

[bkchr]

Ty! I'm quite interesting in this and would be happy to merge this in the near future.

[hirschenberger]

Ty! I'm quite interesting in this and would be happy to merge this in the near future.

I try to deliver ASAP

[hirschenberger]

@bkchr What about RuntimeDebugNoBound? Also deprecate and substitute?

[bkchr]

@bkchr What about RuntimeDebugNoBound? Also deprecate and substitute?

Yes!

[hirschenberger]

@bkchr Hey Basti, after subsituting all RtDebug und RtDebugNoBound I get a lot of errors like:

error[E0277]: `A` doesn't implement `std::fmt::Debug`
   --> substrate/frame/support/src/traits/tokens/fungible/mod.rs:204:25
    |
204 |     > Consideration<A> for FreezeConsideration<A, F, R, D>
    |                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ `A` cannot be formatted using `{:?}` because it doesn't implement `std::fmt::Debug`

So there are many generic type parameters missing a Debug bound. Should I extend these all?

[paritytech-cicd-pr]

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: cargo-clippy
Logs: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/6085157

[bkchr]

RtDebugNoBound

You can not just replace this with Debug, it should be replaced by DebugNoBound to not require bounds for the generic types.

[hirschenberger]

Still working on this, I tried to build my own refactoring tool using syn and it works ok, but there are some nasty edge-cases.

I also found the nice ast-grep tool which I'm giving a quick try.

[bkchr]

@hirschenberger ping.