Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gossip-support: add unittests for update authorities #3258

Merged
merged 12 commits into from
Feb 19, 2024
1 change: 1 addition & 0 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions polkadot/node/network/gossip-support/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -38,5 +38,6 @@ polkadot-node-subsystem-test-helpers = { path = "../../subsystem-test-helpers" }

assert_matches = "1.4.0"
async-trait = "0.1.74"
parking_lot = "0.12.1"
lazy_static = "1.4.0"
quickcheck = "1.0.3"
26 changes: 24 additions & 2 deletions polkadot/node/network/gossip-support/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -271,8 +271,30 @@ where
)
.await?;
}
// authority_discovery is just a cache so let's try every leaf to detect if there
// are new authorities there.
// authority_discovery is just a cache so let's try every time we try to re-connect
// if new authorities are present.
self.update_authority_ids(sender, session_info.discovery_keys).await;
} else if let Some(session_index) = self
.last_session_index
.filter(|last_session_index| *last_session_index == current_index)
{
// authority_discovery is just a cache so let's try every leaf from the current
// session if there are new authorities detected and inform the needed subsystems.
let session_info =
util::request_session_info(leaf, session_index, sender).await.await??;

let session_info = match session_info {
Some(s) => s,
None => {
gum::warn!(
relay_parent = ?leaf,
session_index = self.last_session_index,
"Failed to get session info.",
);

continue
},
};
self.update_authority_ids(sender, session_info.discovery_keys).await;
}
}
Expand Down
Loading
Loading