-
Notifications
You must be signed in to change notification settings - Fork 666
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deploy pallet-parameters
to rococo and fix dynamic_params name expand
#4006
Merged
Commits on Apr 5, 2024
-
Use pascal case instead of class case for runtime param names
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Configuration menu - View commit details
-
Copy full SHA for a88932f - Browse repository at this point
Copy the full SHA a88932fView commit details -
Deploy pallet parameters to rococo
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Configuration menu - View commit details
-
Copy full SHA for ec1c99d - Browse repository at this point
Copy the full SHA ec1c99dView commit details -
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Configuration menu - View commit details
-
Copy full SHA for 9d8ddaa - Browse repository at this point
Copy the full SHA 9d8ddaaView commit details -
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Configuration menu - View commit details
-
Copy full SHA for 94af5f0 - Browse repository at this point
Copy the full SHA 94af5f0View commit details -
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Configuration menu - View commit details
-
Copy full SHA for f74782a - Browse repository at this point
Copy the full SHA f74782aView commit details -
[parachain-template] benchmarks into
mod benchmarks
(#3818)This PR introduces a dedicated module for benchmarks within the parachain runtime. By segregating benchmarks into their own module, we achieve a cleaner project structure and improved readability, facilitating easier maintenance and updates. ### Key Changes: - **New Benchmarks Module**: A new file `benchmarks.rs` is added, encapsulating the benchmarking code for various pallets. - **Refactoring `lib.rs`**: The main runtime library file (`lib.rs`) has been updated to reflect the extraction of benchmark definitions. By moving these definitions to `benchmarks.rs`, we reduce clutter in `lib.rs`, streamlining the runtime's core logic and configuration. ### Benefits of This Refactoring: - **Focused Benchmarking**: Developers can now easily locate and modify benchmarks without navigating through the core runtime logic, enabling targeted performance improvements. - **Cleaner Codebase**: Segregating benchmarks from the main runtime logic helps maintain a clean, well-organized codebase, simplifying navigation and maintenance. - **Scalability**: As the parachain evolves, adding or updating benchmarks becomes more straightforward, supporting scalability and adaptability of the runtime. ### Summary of Changes: - Created `benchmarks.rs` to house the benchmarking suite. - Streamlined `lib.rs` by removing the inlined benchmark definitions and linking to the new benchmarks module. --------- Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 239a334 - Browse repository at this point
Copy the full SHA 239a334View commit details -
".git/.scripts/commands/bench/bench.sh" --subcommand=pallet --runtime…
…=rococo --target_dir=polkadot --pallet=pallet_parameters
command-bot committedApr 5, 2024 Configuration menu - View commit details
-
Copy full SHA for 86b7ed3 - Browse repository at this point
Copy the full SHA 86b7ed3View commit details -
Configuration menu - View commit details
-
Copy full SHA for dd5e805 - Browse repository at this point
Copy the full SHA dd5e805View commit details -
Configuration menu - View commit details
-
Copy full SHA for bcfefa7 - Browse repository at this point
Copy the full SHA bcfefa7View commit details
Commits on Apr 8, 2024
-
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Configuration menu - View commit details
-
Copy full SHA for 0ecf273 - Browse repository at this point
Copy the full SHA 0ecf273View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0512e7d - Browse repository at this point
Copy the full SHA 0512e7dView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.