Implement CheckMetadataHash extension (#4274)
#4619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This implements the `CheckMetadataHash` extension as described in [RFC78](https://polkadot-fellows.github.io/RFCs/approved/0078-merkleized-metadata.html). Besides the signed extension, the `substrate-wasm-builder` is extended to support generating the metadata-hash. Closes: #291 --------- Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> Co-authored-by: joe petrowski <25483142+joepetrowski@users.noreply.github.com> Co-authored-by: Liam Aharon <liam.aharon@hotmail.com> Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>
|
The CI pipeline was cancelled due to failure one of the required jobs. |
bkchr
commented
May 28, 2024
| //! trust the metadata to be correct. It is very important for the metadata to be correct or | ||
| //! otherwise an attacker could change them in a way that the offline wallet decodes a transaction | ||
| //! in a different way than what it will be decoded to on chain. So, the user may signs an incorrect | ||
| //! transaction leading to unexpecting behavior. |
There was a problem hiding this comment.
@PolkadotDom ty, this is acutally a backport. If you like, please open a pr against master with your suggestions, ty!
ggwpez
approved these changes
May 28, 2024
EgorPopelyaev
approved these changes
May 29, 2024
|
This pull request has been mentioned on Polkadot Forum. There might be relevant details there: https://forum.polkadot.network/t/new-polkadot-ledger-app/8817/1 |
dnjscksdn98
pushed a commit
to bifrost-platform/polkadot-sdk
that referenced
this pull request
Sep 20, 2024
…#4619) This implements the `CheckMetadataHash` extension as described in [RFC78](https://polkadot-fellows.github.io/RFCs/approved/0078-merkleized-metadata.html). Besides the signed extension, the `substrate-wasm-builder` is extended to support generating the metadata-hash. Closes: paritytech#291 --------- Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> Co-authored-by: joe petrowski <25483142+joepetrowski@users.noreply.github.com> Co-authored-by: Liam Aharon <liam.aharon@hotmail.com> Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements the
CheckMetadataHashextension as described in RFC78.Besides the signed extension, the
substrate-wasm-builderis extended to support generating the metadata-hash.Closes: #291