Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ported cargo-check-each-crate-macos to GitHub actions #5386

Closed
wants to merge 39 commits into from
Closed

Ported cargo-check-each-crate-macos to GitHub actions #5386

wants to merge 39 commits into from

Conversation

Bullrich
Copy link
Contributor

@Bullrich Bullrich commented Aug 16, 2024 •
edited
Loading

Resolves paritytech/ci_cd#1021

Ported the gitlab job to run on GitHub actions.

@Bullrich Bullrich added R0-silent Changes should not be mentioned in any release notes GHA-migration Temporary label for migrating CI to GHA labels Aug 16, 2024
@Bullrich Bullrich self-assigned this Aug 16, 2024
@Bullrich Bullrich requested a review from alvicsam August 16, 2024 13:47
@Bullrich Bullrich marked this pull request as ready for review August 16, 2024 16:11
@Bullrich Bullrich requested review from a team as code owners August 16, 2024 16:11
@Bullrich Bullrich force-pushed the ci/gha-migration/cargo-check-each-crate-macos branch from 53af713 to 996dbd2 Compare August 16, 2024 16:11
@Bullrich Bullrich requested a review from mordamax August 16, 2024 17:25
@Bullrich
Copy link
Contributor Author

@alvicsam @lovelaced @mordamax this PR is ready for review.

I have tried both with macos-latest and macos-latest-xlarge

Both of them can complete the job. The first one takes more than 90 minutes, the second one takes around 45 minutes.

Which one should I assign as the runner for this job?

@lovelaced
Copy link

@alvicsam @lovelaced @mordamax this PR is ready for review.

I have tried both with macos-latest and macos-latest-xlarge

Both of them can complete the job. The first one takes more than 90 minutes, the second one takes around 45 minutes.

Which one should I assign as the runner for this job?

What is the cost basis for each? (which one is cheaper to run given the time it takes :D?)

@Bullrich
Copy link
Contributor Author

Bullrich commented Aug 19, 2024 •
edited
Loading

@alvicsam @lovelaced @mordamax this PR is ready for review.
I have tried both with macos-latest and macos-latest-xlarge
Both of them can complete the job. The first one takes more than 90 minutes, the second one takes around 45 minutes.
Which one should I assign as the runner for this job?

What is the cost basis for each? (which one is cheaper to run given the time it takes :D?)

From the documentation it seems that the costs per minute are:

  • macos-latest: $0.08
  • macos-latest-xlarge: $0.16

So, seeing the time it takes, we could summarize the total price:

  • macos-latest: Around $7.20 per run (90 minutes)
  • macos-latest-xlarge: Around $7.20 per run (45 minutes)

As the xlarge cost double but takes half of the time they cost the same 🤣

@Bullrich Bullrich force-pushed the ci/gha-migration/cargo-check-each-crate-macos branch 6 times, most recently from 9cfb14d to 9b7ffbf Compare August 21, 2024 09:29
@Bullrich Bullrich force-pushed the ci/gha-migration/cargo-check-each-crate-macos branch 3 times, most recently from 2787457 to d1b58f4 Compare August 29, 2024 13:35
@Bullrich Bullrich mentioned this pull request Aug 29, 2024
Merged
github-merge-queue bot pushed a commit that referenced this pull request Aug 30, 2024
@Bullrich
Added mac-setup script (#5528)
18e9504 
This is used for the steps that use the `macos` runner.

It installs the Rust version that we are using in the [`forklift`
image](https://github.com/paritytech/polkadot-sdk/blob/master/.github/env).

To be used in #5386.
mordamax pushed a commit that referenced this pull request Aug 30, 2024
@Bullrich @mordamax
Added mac-setup script (#5528)
ea958d2 
This is used for the steps that use the `macos` runner.

It installs the Rust version that we are using in the [`forklift`
image](https://github.com/paritytech/polkadot-sdk/blob/master/.github/env).

To be used in #5386.
Bullrich and others added 24 commits September 6, 2024 09:18
@Bullrich
removed custom workflow in favor of existing
49027d7 
A workflow already exists named `Check Cargo Check Runtimes`. We will add this job into that workflow
@Bullrich
added macOS runner
7ff62ba
@Bullrich
added brew command first
a357cdb
@Bullrich
added rustup as a brew dependency
67fddcd
@Bullrich
added missing chain
3844395
@Bullrich
preinstall rust
b56d4b6
@Bullrich
added missing -y command
381bcc8
@Bullrich
added nightly install
e0d7ab2
@Bullrich
added source
7a9be7b
@Bullrich
test - install rust from brew
dfc3121
@Bullrich
added generic toolchain
c445a74
@Bullrich
added rustup init
5635134
@Bullrich
removed old script
feedc60 
Replaced it for brew's installation
@Bullrich
removed time command
902919a
@Bullrich
manually triggered cargo
8582114
@Bullrich @bkchr
renamed job
173b5f2 
Co-authored-by: Bastian Köcher <git@kchr.de>
@Bullrich
freed some storage
11e8565
@Bullrich
fixed invalid array name
08f0a6a
@Bullrich
added test to run each mac crate individually
d7c6f48
@Bullrich
disabled forklift
9d1b4f0
@Bullrich
added step to set up mac image
fd2ec7e
@Bullrich
WIP - removed source command
db29cd5
@Bullrich
added sourc emethod
ef27195
@Bullrich
renamed the step
103e1d2
@Bullrich Bullrich force-pushed the ci/gha-migration/cargo-check-each-crate-macos branch from 39c98eb to 103e1d2 Compare September 6, 2024 12:19
@Bullrich Bullrich mentioned this pull request Sep 6, 2024
Closed
@Bullrich
removed if condition
f29dc35 
It is already available in the needed step.
@alvicsam
Copy link
Contributor

I suggest closing this PR because this one was already merged

@Bullrich
Copy link
Contributor Author

Bullrich commented Oct 1, 2024

Closed in favour of #5690

@Bullrich Bullrich closed this Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bkchr bkchr bkchr left review comments

@EgorPopelyaev EgorPopelyaev EgorPopelyaev approved these changes

@alvicsam alvicsam Awaiting requested review from alvicsam

@mordamax mordamax Awaiting requested review from mordamax

Assignees

@Bullrich Bullrich

Labels
GHA-migration Temporary label for migrating CI to GHA R0-silent Changes should not be mentioned in any release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Bullrich @lovelaced @alvicsam @bkchr @EgorPopelyaev