Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Install prdoc from Parity fork #5625

Merged
merged 3 commits into from
Sep 9, 2024
Merged

Install prdoc from Parity fork #5625

merged 3 commits into from
Sep 9, 2024
+2 −2

Conversation

ggwpez
Copy link
Member

@ggwpez ggwpez commented Sep 6, 2024

Prdoc is now published as a Parity fork under the parity-prdoc crate after the directions diverged from the ideas of the original creator (discussions here and here).
Now updating the install instructions here.

@ggwpez
Use new prdoc crates-io package
4a0ec3d
@ggwpez
Docker image
2d60388 
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@ggwpez ggwpez requested review from a team as code owners September 6, 2024 13:58
@ggwpez ggwpez added the R0-silent Changes should not be mentioned in any release notes label Sep 6, 2024
@paritytech-review-bot paritytech-review-bot bot requested a review from a team September 6, 2024 14:19
gui1117
gui1117 approved these changes Sep 8, 2024
View reviewed changes
Copy link
Contributor

@gui1117 gui1117 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR is good to me,

But I hope people won't get confused about which fork to download from, as they produce a binary with the same name.
(Maybe it could even be considered an attack vector at some point, but I think right now is ok)

@ggwpez ggwpez added this pull request to the merge queue Sep 9, 2024
Merged via the queue into master with commit d2e962f Sep 9, 2024
199 of 202 checks passed
@ggwpez ggwpez deleted the oty-prdoc-install branch September 9, 2024 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gui1117 gui1117 gui1117 approved these changes

@alvicsam alvicsam alvicsam approved these changes

Assignees
No one assigned
Labels
R0-silent Changes should not be mentioned in any release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ggwpez @gui1117 @alvicsam