litep2p/discovery: Fix memory leak in litep2p.public_addresses()
#5998
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
lexnv
added
T0-node
bkchr
approved these changes
Oct 9, 2024
Co-authored-by: Bastian Köcher <git@kchr.de>
lexnv
added
the
A4-needs-backport
…exnv/bound-dht-addreses
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
|
Why do we have so many (>32) external addresses confirmed? Is there a linked issue in polkadot-sdk? |
skunert
approved these changes
Oct 11, 2024
dmitry-markin
approved these changes
Oct 11, 2024
This issue was reproduced in Rococo on litep2p validators, don't believe we have an gitissue for it. It looks like over time peers report via identify protocol connections on different ports. |
Co-authored-by: Dmitry Markin <dmitry@markin.tech>
Co-authored-by: Dmitry Markin <dmitry@markin.tech>
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ensures that the
litep2p.public_addresses()never grows indefinitely./identifyprotocolThis PR adds a new
ExternalAddressExpiredevent to the litep2p/discovery process.Substrate uses an LRU
address_confirmationsbounded to 32 address entries.The oldest entry is propagated via the
ExternalAddressExpiredevent when a new address is added to the list (if capacity is exceeded).The expired address is then removed from the
litep2p.public_addresses(), effectively limiting its size to 32 entries (the size ofaddress_confirmationsLRU).cc @paritytech/networking @alexggh