Upgrade Proxy and Multisig pallets to Benchmarking V2 #6018
+181
−116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
re-gius
added
T2-pallets
seadanda
reviewed
Oct 11, 2024
| @@ -20,8 +20,7 @@ | |||
| #![cfg(feature = "runtime-benchmarks")] | |||
|
|
|||
| use super::*; | |||
| #[allow(deprecated)] | |||
| use frame::benchmarking::v1::*; | |||
| use frame::benchmarking::v2::*; | |||
There was a problem hiding this comment.
Suggested change
| use frame::benchmarking::v2::*; | |
| use frame::benchmarking::prelude::*; |
edited
There was a problem hiding this comment.
Ah wait that's the umbrella crate. You should be able to use that too, v2 doesn't exist at the top level though, I think you get it via the prelude. edited the suggestion to update it
| @@ -22,8 +22,7 @@ | |||
| use super::*; | |||
| use crate::Pallet as Proxy; | |||
| use alloc::{boxed::Box, vec}; | |||
| #[allow(deprecated)] | |||
| use frame::benchmarking::v1::*; | |||
| use frame::benchmarking::v2::*; | |||
There was a problem hiding this comment.
Suggested change
| use frame::benchmarking::v2::*; | |
| use frame::benchmarking::prelude::*; |
Co-authored-by: Dónal Murray <donal.murray@parity.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sub-task of PR #5995
Integration
These changes should not require any integration effort.