remove pallet::getter from pallet-offences #6027
Open
+31
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zebedeusz
force-pushed
the
zebedeusz/remove_getter_pallet_offences
branch
from
6d121c6
to
b74ddc3
Compare
seadanda
reviewed
Oct 11, 2024
|
|
||
| crates: | ||
| - name: pallet-offences | ||
| bump: patch |
There was a problem hiding this comment.
Removing the getter is a breaking (major) change unless you add a function with the same signature. I'd go with adding the new function but marking it as deprecated to avoid the breakage but letting people know that it is deprecated and that they should use Reports::<T>::get(id) instead.
seadanda
reviewed
Oct 11, 2024
Comment on lines
+43
to
+46
| // when | ||
| let stored_offence_details = Reports::<Runtime>::get(report_id); | ||
|
|
||
| // then |
There was a problem hiding this comment.
Suggested change
| // when | |
| let stored_offence_details = Reports::<Runtime>::get(report_id); | |
| // then | |
| #[allow(deprecated)] | |
| let stored_offence_details = Offences::reports(report_id); | |
| assert_eq!(stored_offence_details, Some(offence_details.clone())); | |
| let stored_offence_details = Reports::<Runtime>::get(report_id); |
This new part of the test should pass to avoid a breaking change
|
Yeah, we need you to create a new public function which does the same thing as the getter here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Part of #3326
Removes pallet::getter from pallet-offences from type
Reports.Adds a test to verify that retrieval of
Reportsstill works with storage::getter.