Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Commit

Permalink
Remove ParityDb migration tests (#7612)
Browse files Browse the repository at this point in the history
  • Loading branch information
altonen authored and s0me0ne-unkn0wn committed Aug 15, 2023
1 parent 730a1c8 commit 04ae532
Showing 1 changed file with 0 additions and 119 deletions.
119 changes: 0 additions & 119 deletions node/service/src/parachains_db/upgrade.rs
Original file line number Diff line number Diff line change
Expand Up @@ -278,17 +278,6 @@ pub(crate) fn paritydb_version_3_config(path: &Path) -> parity_db::Options {
options
}

/// Database configuration for version 0. This is useful just for testing.
#[cfg(test)]
pub(crate) fn paritydb_version_0_config(path: &Path) -> parity_db::Options {
let mut options =
parity_db::Options::with_columns(&path, super::columns::v1::NUM_COLUMNS as u8);
options.columns[super::columns::v3::COL_AVAILABILITY_META as usize].btree_index = true;
options.columns[super::columns::v3::COL_CHAIN_SELECTION_DATA as usize].btree_index = true;

options
}

/// Migration from version 0 to version 1.
/// Cases covered:
/// - upgrading from v0.9.23 or earlier -> the `dispute coordinator column` was changed
Expand Down Expand Up @@ -332,82 +321,6 @@ mod tests {
*,
};

#[test]
fn test_paritydb_migrate_0_to_1() {
use parity_db::Db;

let db_dir = tempfile::tempdir().unwrap();
let path = db_dir.path();
{
let db = Db::open_or_create(&paritydb_version_0_config(&path)).unwrap();

db.commit(vec![
(COL_DISPUTE_COORDINATOR_DATA as u8, b"1234".to_vec(), Some(b"somevalue".to_vec())),
(COL_AVAILABILITY_META as u8, b"5678".to_vec(), Some(b"somevalue".to_vec())),
])
.unwrap();
}

try_upgrade_db(&path, DatabaseKind::ParityDB).unwrap();

let db = Db::open(&paritydb_version_1_config(&path)).unwrap();
assert_eq!(db.get(COL_DISPUTE_COORDINATOR_DATA as u8, b"1234").unwrap(), None);
assert_eq!(
db.get(COL_AVAILABILITY_META as u8, b"5678").unwrap(),
Some("somevalue".as_bytes().to_vec())
);
}

#[test]
fn test_paritydb_migrate_1_to_2() {
use parity_db::Db;

let db_dir = tempfile::tempdir().unwrap();
let path = db_dir.path();

// We need to properly set db version for upgrade to work.
fs::write(version_file_path(path), "1").expect("Failed to write DB version");

{
let db = Db::open_or_create(&paritydb_version_1_config(&path)).unwrap();

// Write some dummy data
db.commit(vec![(
COL_DISPUTE_COORDINATOR_DATA as u8,
b"1234".to_vec(),
Some(b"somevalue".to_vec()),
)])
.unwrap();

assert_eq!(db.num_columns(), columns::v1::NUM_COLUMNS as u8);
}

try_upgrade_db(&path, DatabaseKind::ParityDB).unwrap();

let db = Db::open(&paritydb_version_2_config(&path)).unwrap();

assert_eq!(db.num_columns(), columns::v2::NUM_COLUMNS as u8);

assert_eq!(
db.get(COL_DISPUTE_COORDINATOR_DATA as u8, b"1234").unwrap(),
Some("somevalue".as_bytes().to_vec())
);

// Test we can write the new column.
db.commit(vec![(
COL_SESSION_WINDOW_DATA as u8,
b"1337".to_vec(),
Some(b"0xdeadb00b".to_vec()),
)])
.unwrap();

// Read back data from new column.
assert_eq!(
db.get(COL_SESSION_WINDOW_DATA as u8, b"1337").unwrap(),
Some("0xdeadb00b".as_bytes().to_vec())
);
}

#[test]
fn test_rocksdb_migrate_1_to_2() {
use kvdb::{DBKey, DBOp};
Expand Down Expand Up @@ -467,38 +380,6 @@ mod tests {
);
}

#[test]
fn test_paritydb_migrate_2_to_3() {
use parity_db::Db;

let db_dir = tempfile::tempdir().unwrap();
let path = db_dir.path();
let test_key = b"1337";

// We need to properly set db version for upgrade to work.
fs::write(version_file_path(path), "2").expect("Failed to write DB version");

{
let db = Db::open_or_create(&paritydb_version_2_config(&path)).unwrap();

// Write some dummy data
db.commit(vec![(
COL_SESSION_WINDOW_DATA as u8,
test_key.to_vec(),
Some(b"0xdeadb00b".to_vec()),
)])
.unwrap();

assert_eq!(db.num_columns(), columns::v2::NUM_COLUMNS as u8);
}

try_upgrade_db(&path, DatabaseKind::ParityDB).unwrap();

let db = Db::open(&paritydb_version_3_config(&path)).unwrap();

assert_eq!(db.num_columns(), columns::v3::NUM_COLUMNS as u8);
}

#[test]
fn test_rocksdb_migrate_2_to_3() {
use kvdb_rocksdb::{Database, DatabaseConfig};
Expand Down

0 comments on commit 04ae532

Please sign in to comment.