-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
runtime/kusama/src/lib.rs
Outdated
@@ -814,6 +815,9 @@ impl InstanceFilter<Call> for ProxyType { | |||
Call::Staking(..) | Call::Utility(utility::Call::batch(..)) | |||
| Call::Utility(utility::Call::as_limited_sub(..)) | |||
), | |||
ProxyType::RegistrarJudgement => matches!(c, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
probably worth including utility.batch
also.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, that's exactly what I want to add :) I was looking for how to add batch but only a given method.
I have also (not pushed yet) the change for westend and polkadot.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@chevdor if you directly add Call::Utility(utility::Call::batch(..))
as is done above, the other filters will continue to apply through to the batch call.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i.e. you will only be able to batch to make the specific calls you have whitelisted. You of course can verify this with a dev node or something.
This feature can be tested in the UI under settings/dev by adding the following type:
|
No issue here but I am leaving it as draft until I can take a bit more time to test for myself. |
129a8c7
to
f385365
Compare
I tested the following on kusama-dev manually:
|
e879ce6
to
9c6a5d8
Compare
Rebased master |
This PR adds a new ProxyType:
IdentityJudgement
, allowing onlyIdentity.provideJudgement
either as single call or batched call.The main usage is for identity registrars who want to automate their process without exposing the registrar's main account.
Proxy setup:
Usage:
Fix #1290