This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Commits on Jul 10, 2020
-
Configuration menu - View commit details
-
Copy full SHA for aee251a - Browse repository at this point
Copy the full SHA aee251aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1719606 - Browse repository at this point
Copy the full SHA 1719606View commit details -
convert subsystem-util from crate to module in subsystem
The point of making a sub-crate is to ensure that only the necessary parts of a program get compiled; if a dependent package needed only subsystem-util, and not subsystem, then subsystem wouldn't need to be compiled. However, that will never happen: subsystem-util depends on subsystem::messages, so subsystem will always be compiled. Therefore, it makes more sense to add it as a module in the existing crate than as a new and distinct crate.
Configuration menu - View commit details
-
Copy full SHA for bc5efd0 - Browse repository at this point
Copy the full SHA bc5efd0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 145dd58 - Browse repository at this point
Copy the full SHA 145dd58View commit details -
Configuration menu - View commit details
-
Copy full SHA for e76239d - Browse repository at this point
Copy the full SHA e76239dView commit details -
add struct Validator representing the local validator
This struct can be constructed when the local node is a validator; the constructor fails otherwise. It stores a bit of local data, and provides some utility methods.
Configuration menu - View commit details
-
Copy full SHA for be2be35 - Browse repository at this point
Copy the full SHA be2be35View commit details -
Configuration menu - View commit details
-
Copy full SHA for 32e5c18 - Browse repository at this point
Copy the full SHA 32e5c18View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5d8a8af - Browse repository at this point
Copy the full SHA 5d8a8afView commit details -
Configuration menu - View commit details
-
Copy full SHA for 447ab4a - Browse repository at this point
Copy the full SHA 447ab4aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1d59e66 - Browse repository at this point
Copy the full SHA 1d59e66View commit details -
Configuration menu - View commit details
-
Copy full SHA for fa46a8a - Browse repository at this point
Copy the full SHA fa46a8aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 36b3367 - Browse repository at this point
Copy the full SHA 36b3367View commit details -
implement generic job-manager subsystem impl
This means that the work of implementing a subsystem boils down to implementing the job, and then writing an appropriate type definition, i.e. pub type CandidateBackingSubsystem<Spawner, Context> = util::JobManager<Spawner, Context, CandidateBackingJob>;
Configuration menu - View commit details
-
Copy full SHA for 91e301b - Browse repository at this point
Copy the full SHA 91e301bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3a47236 - Browse repository at this point
Copy the full SHA 3a47236View commit details -
Configuration menu - View commit details
-
Copy full SHA for 38110d5 - Browse repository at this point
Copy the full SHA 38110d5View commit details -
Configuration menu - View commit details
-
Copy full SHA for b5d28ce - Browse repository at this point
Copy the full SHA b5d28ceView commit details -
Configuration menu - View commit details
-
Copy full SHA for 93fe700 - Browse repository at this point
Copy the full SHA 93fe700View commit details -
Configuration menu - View commit details
-
Copy full SHA for cca7d4b - Browse repository at this point
Copy the full SHA cca7d4bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 841579d - Browse repository at this point
Copy the full SHA 841579dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 38ee247 - Browse repository at this point
Copy the full SHA 38ee247View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8bb08b8 - Browse repository at this point
Copy the full SHA 8bb08b8View commit details
Commits on Jul 13, 2020
-
Configuration menu - View commit details
-
Copy full SHA for fa595c2 - Browse repository at this point
Copy the full SHA fa595c2View commit details -
impl Stream for Jobs<Spawner, Job>
This turns out to be relatively complicated and requires some unsafe code, so we'll want either detailed review, or to choose to revert this commit.
2Configuration menu - View commit details
-
Copy full SHA for 940c111 - Browse repository at this point
Copy the full SHA 940c111View commit details -
Configuration menu - View commit details
-
Copy full SHA for 11772f5 - Browse repository at this point
Copy the full SHA 11772f5View commit details -
Configuration menu - View commit details
-
Copy full SHA for dc9e12c - Browse repository at this point
Copy the full SHA dc9e12cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 802981a - Browse repository at this point
Copy the full SHA 802981aView commit details -
reenvision the subsystem requests as an extension trait
This works within `util.rs`, but fails in `core/backing/src/lib.rs`, because we don't actually create the struct soon enough. Continuing down this path would imply substantial rewriting.
Configuration menu - View commit details
-
Copy full SHA for a5639e3 - Browse repository at this point
Copy the full SHA a5639e3View commit details -
Revert "reenvision the subsystem requests as an extension trait"
This reverts commit a5639e3. The fact is, the new API is more complicated to no real benefit.
Configuration menu - View commit details
-
Copy full SHA for e7f5276 - Browse repository at this point
Copy the full SHA e7f5276View commit details
Commits on Jul 14, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 0eaca1b - Browse repository at this point
Copy the full SHA 0eaca1bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 863d733 - Browse repository at this point
Copy the full SHA 863d733View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1e14746 - Browse repository at this point
Copy the full SHA 1e14746View commit details -
make most node-core-backing types private
Now the only public types exposed in that module are CandidateBackingSubsystem and ToJob. While ideally we could reduce the public interface to only the former type, that doesn't work because ToJob appears in the public interface of CandidateBackingSubsystem. This also involves changing the definition of CandidateBackingSubsystem; it is no longer a typedef, but a struct wrapping the job manager.
Configuration menu - View commit details
-
Copy full SHA for e3f76a4 - Browse repository at this point
Copy the full SHA e3f76a4View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.