Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Add test suite and minor refinements to the utility subsystem #1403

Merged
merged 17 commits into from
Jul 21, 2020
Merged

Add test suite and minor refinements to the utility subsystem #1403

merged 17 commits into from
Jul 21, 2020

Commits on Jul 14, 2020

  1. get conclude signal working properly; don't allocate a vector

    @coriolinus
    coriolinus committed Jul 14, 2020
    Configuration menu
    Copy the full SHA
    c72e59c View commit details
    Browse the repository at this point in the history

  2. wip: add test suite / example / explanation for using utility subsystem 

    Unfortunately, the test fails right now for reasons which seem
very odd. Just have to keep poking at it.
    @coriolinus
    coriolinus committed Jul 14, 2020
    Configuration menu
    Copy the full SHA
    00bbe47 View commit details
    Browse the repository at this point in the history

Commits on Jul 16, 2020

  1. explicitly import everything

    @coriolinus
    coriolinus committed Jul 16, 2020
    Configuration menu
    Copy the full SHA
    837a62a View commit details
    Browse the repository at this point in the history

  2. fix subsystem-util test 

    The root problem here was two-fold:

- there was a circular dependency from subsystem -> test-helpers/subsystem ->
  subsystem
- cfg(test) doesn't propagate between crates

The solution: move the subsystem test helpers into a sub-module
within subsystem. Publicly export them from the previous location
so no other code breaks.

Doing this has an additional benefit: it ensures that no production
code can ever accidentally use the subsystem helpers, as they are compile-
gated on cfg(test).
    @coriolinus
    coriolinus committed Jul 16, 2020
    Configuration menu
    Copy the full SHA
    5601550 View commit details
    Browse the repository at this point in the history

  3. fully commit to moving test helpers into a subsystem module

    @coriolinus
    coriolinus committed Jul 16, 2020
    Configuration menu
    Copy the full SHA
    3ff4f66 View commit details
    Browse the repository at this point in the history

  4. add some more tests

    @coriolinus
    coriolinus committed Jul 16, 2020
    Configuration menu
    Copy the full SHA
    356c26f View commit details
    Browse the repository at this point in the history

Commits on Jul 17, 2020

  1. get rid of log tests in favor of real error forwarding 

    It's not obvious whether we'll ever really want to chase down
these errors outside a testing context, but having the capability
won't hurt.
    @coriolinus
    coriolinus committed Jul 17, 2020
    Configuration menu
    Copy the full SHA
    f0c23de View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/master' into prgn-subsystem-util… 

    …-test-suite
    @coriolinus
    coriolinus committed Jul 17, 2020
    Configuration menu
    Copy the full SHA
    68a745d View commit details
    Browse the repository at this point in the history

  3. fix issue which caused test to hang on osx

    @coriolinus
    coriolinus committed Jul 17, 2020
    Configuration menu
    Copy the full SHA
    66e7d50 View commit details
    Browse the repository at this point in the history

  4. only require that job errors are PartialEq when testing 

    also fix polkadot-node-core-backing tests
    @coriolinus
    coriolinus committed Jul 17, 2020
    Configuration menu
    Copy the full SHA
    a9b49af View commit details
    Browse the repository at this point in the history

  5. get rid of any notion of partialeq

    @coriolinus
    coriolinus committed Jul 17, 2020
    Configuration menu
    Copy the full SHA
    812b35a View commit details
    Browse the repository at this point in the history

Commits on Jul 20, 2020

  1. rethink testing 

    Combine tests of starting and stopping job: leaving a test executor
with a job running was pretty clearly the cause of the sometimes-hang.

Also, add a timeout so tests _can't_ hang anymore; they just fail
after a while.
    @coriolinus
    coriolinus committed Jul 20, 2020
    Configuration menu
    Copy the full SHA
    7e758b5 View commit details
    Browse the repository at this point in the history

  2. rename fwd_errors -> forward_errors

    @coriolinus
    coriolinus committed Jul 20, 2020
    Configuration menu
    Copy the full SHA
    6672e2a View commit details
    Browse the repository at this point in the history

  3. warn on error propagation failure

    @coriolinus
    coriolinus committed Jul 20, 2020
    Configuration menu
    Copy the full SHA
    6b056bf View commit details
    Browse the repository at this point in the history

  4. Merge remote-tracking branch 'origin/master' into prgn-subsystem-util… 

    …-test-suite
    @coriolinus
    coriolinus committed Jul 20, 2020
    Configuration menu
    Copy the full SHA
    f3aa719 View commit details
    Browse the repository at this point in the history

  5. fix unused import leftover from merge

    @coriolinus
    coriolinus committed Jul 20, 2020
    Configuration menu
    Copy the full SHA
    bcd0a6d View commit details
    Browse the repository at this point in the history

  6. derive eq for subsystemerror

    @coriolinus
    coriolinus authored Jul 20, 2020
    Configuration menu
    Copy the full SHA
    5b464b0 View commit details
    Browse the repository at this point in the history