Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Companion PR for #7138 (WeightInfo for Scheduler) #1734

Merged
2 commits merged into from
Sep 18, 2020
Merged

Companion PR for #7138 (WeightInfo for Scheduler) #1734

2 commits merged into from
Sep 18, 2020

Conversation

shawntabrizi
Copy link
Member

@shawntabrizi shawntabrizi commented Sep 18, 2020 •
edited
Loading

This PR adds the WeigtInfo struct and a new associated type MaxScheduledPerBlock which introduces a soft warning when too many items are in the scheduler queue.

paritytech/substrate#7138

@github-actions github-actions bot added the A0-please_review Pull request needs code review. label Sep 18, 2020
@shawntabrizi shawntabrizi mentioned this pull request Sep 18, 2020
Merged
@ghost
Copy link

ghost commented Sep 18, 2020

Waiting for commit status.

@ghost
Copy link

ghost commented Sep 18, 2020

Checks failed; merge aborted.

@shawntabrizi shawntabrizi added B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. A8-mergeoncegreen and removed A0-please_review Pull request needs code review. labels Sep 18, 2020
@shawntabrizi
Copy link
Member Author

bot merge

@ghost
Copy link

ghost commented Sep 18, 2020

Missing process info; check that the PR belongs to a project column.

Merge can be attempted if:

  • The PR has approval from two core-devs (or one if the PR is labelled insubstantial).
  • The PR has approval from a member of substrateteamleads.
  • The PR is attached to a project column and has approval from the project owner.

See https://github.com/paritytech/parity-processbot#faq

@shawntabrizi shawntabrizi added the A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). label Sep 18, 2020
@shawntabrizi
Copy link
Member Author

bot merge

@ghost
Copy link

ghost commented Sep 18, 2020

Waiting for commit status.

@ghost
Copy link

ghost commented Sep 18, 2020

Merge failed: "At least 3 approving reviews are required by reviewers with write access."

@andresilva andresilva mentioned this pull request Sep 18, 2020
Merged
@bkchr bkchr mentioned this pull request Sep 18, 2020
Closed
@bkchr
Copy link
Member

bkchr commented Sep 18, 2020

bot merge

@ghost
Copy link

ghost commented Sep 18, 2020

Trying merge.

@ghost
Copy link

ghost commented Sep 18, 2020

Merge failed: "At least 3 approving reviews are required by reviewers with write access."

@andresilva
Copy link
Contributor

bot merge

@ghost
Copy link

ghost commented Sep 18, 2020

Trying merge.

@ghost ghost merged commit 91fe0da into master Sep 18, 2020
@ghost ghost deleted the shawntabrizi-scheduler-weightinfo branch September 18, 2020 18:11
ordian added a commit that referenced this pull request Sep 21, 2020
@ordian
Merge branch 'master' into prgn-remove-old-service-second-try
036080b 
* master:
  Bump jsonrpc-core to v15 (#1737)
  Companion PR for #6215 (#1654)
  Companion PR for #7138 (WeightInfo for Scheduler) (#1734)
  Companion PR for Bounties #5715 (#1336)
ordian added a commit that referenced this pull request Sep 22, 2020
@ordian
Merge branch 'master' into ao-validator-discovery-api
9534c2b 
* master:
  Companion for 7155 (WeightInfo for Babe and Grandpa) (#1736)
  Companion PR for #7136 (WeightInfo for Session / Offences) (#1735)
  Bump jsonrpc-core to v15 (#1737)
  Companion PR for #6215 (#1654)
  Companion PR for #7138 (WeightInfo for Scheduler) (#1734)
  Companion PR for Bounties #5715 (#1336)
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@andresilva andresilva andresilva approved these changes

@bkchr bkchr bkchr approved these changes

@gui1117 gui1117 gui1117 approved these changes

Assignees
No one assigned
Labels
A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@shawntabrizi @bkchr @andresilva @gui1117 @paritytech-ci