Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Diagnostics quality of life improvements #2375

Merged
merged 4 commits into from
Feb 4, 2021
Merged

Diagnostics quality of life improvements #2375

merged 4 commits into from
Feb 4, 2021

Conversation

pepyakin
Copy link
Contributor

@pepyakin pepyakin commented Feb 3, 2021

This PR addresses a few points:

  • It's important to have an ability to track a collation starting from the collator. However, the when collator generates a collation it prints everything but the candidate hash. With this PR we print the candidate hash just after it was produced.
  • Recently a struct CandidateHash was added to make candidate hash manipulations type safe. However that also introduced some inconsistencies how we print it. Namely, there are places where we use a naked hash and there are places where we print using the derived Debug implementation. This PR changes the way we debug format CandidateHash to just the inner hash.
  • Do not print CompressedPoVs guts. If you reached the level of debugging where you use look at the trace-level and look at all messages, you will definitely appreciate CompressedPoV not printing its contents in the decimal format. This PR does just that.

@pepyakin
Implement Debug manually for CandidateHash
6b44e31 
This will make candidate hashes printed consistently without the
`CandidateHash(` and `)` decorations.
@pepyakin
Do not print CompressedPov's guts
1db226d 
It can be overwhelming. Better just use the size.
@pepyakin
Log when candidate is generated
42c62ff
@pepyakin
Print para_id and candidate_hash upon receiving a collation
da4a605
@pepyakin pepyakin added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. labels Feb 3, 2021
@ordian ordian merged commit 4f9e845 into master Feb 4, 2021
@ordian ordian deleted the ser-improve-diagnostics-2 branch February 4, 2021 09:02
ordian added a commit that referenced this pull request Feb 4, 2021
@ordian
merge master
96a3b03 
* master:
  Diagnostics quality of life improvements (#2375)
  Generic request/response infrastructure for Polkadot (#2352)
  Fix bug in statement table (#2369)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ordian ordian ordian approved these changes

@bkchr bkchr bkchr approved these changes

Assignees
No one assigned
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pepyakin @ordian @bkchr