Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Update auctions pallet to FRAME v2 #3031

Merged
2 commits merged into from
May 18, 2021
Merged

Conversation

shaunxw
Copy link
Contributor

@shaunxw shaunxw commented May 16, 2021

Part of #2882

Converts the Auctions pallet to the new pallet attribute macro introduced in #6877.

Following the upgrade guidelines here: https://crates.parity.io/frame_support/attr.pallet.html#upgrade-guidelines.

⚠️ Breaking Change ⚠️

From https://crates.parity.io/frame_support/attr.pallet.html#checking-upgrade-guidelines

storages now use PalletInfo for module_prefix instead of the one given to decl_storage: Thus any use of this pallet in construct_runtime! should be careful to update name in order not to break storage or to upgrade storage (moreover for instantiable pallet). If pallet is published, make sure to warn about this breaking change.

So users of the Auctions pallet must be careful about the name they used in construct_runtime!. Hence the runtime-migration label, which might not be needed depending on the configuration of the Auctions pallet.

@shawntabrizi shawntabrizi added B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit. labels May 16, 2021
@shawntabrizi
Copy link
Member

shawntabrizi commented May 16, 2021

Can confirm that this pallet is imported in Kusama and Westend as Auctions, which matches the decl_storage definition.

@shawntabrizi shawntabrizi requested a review from gui1117 May 16, 2021 15:49
@gui1117
Copy link
Contributor

gui1117 commented May 18, 2021

bot merge

@ghost
Copy link

ghost commented May 18, 2021

Trying merge.

@ghost ghost merged commit 8634431 into paritytech:master May 18, 2021
@KiChjang KiChjang mentioned this pull request May 23, 2021
9 tasks
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants