Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Update crowdloan pallet to FRAME v2 #3036

Merged
1 commit merged into from
May 19, 2021

Conversation

shaunxw
Copy link
Contributor

@shaunxw shaunxw commented May 17, 2021

Part of #2882

Converts the Crowdloan pallet to the new pallet attribute macro introduced in #6877.

Following the upgrade guidelines here: https://crates.parity.io/frame_support/attr.pallet.html#upgrade-guidelines.

⚠️ Breaking Change ⚠️

From https://crates.parity.io/frame_support/attr.pallet.html#checking-upgrade-guidelines

storages now use PalletInfo for module_prefix instead of the one given to decl_storage: Thus any use of this pallet in construct_runtime! should be careful to update name in order not to break storage or to upgrade storage (moreover for instantiable pallet). If pallet is published, make sure to warn about this breaking change.

So users of the Crowdloan pallet must be careful about the name they used in construct_runtime!. Hence the runtime-migration label, which might not be needed depending on the configuration of the Crowdloan pallet.

@shaunxw
Copy link
Contributor Author

shaunxw commented May 17, 2021

This pallet is declared in Kusama and Westend runtime as Crowdloan:

Crowdloan: crowdloan::{Pallet, Call, Storage, Event<T>} = 73,
Crowdloan: crowdloan::{Pallet, Call, Storage, Event<T>} = 64,

Same with in decl_storage:

trait Store for Module<T: Config> as Crowdloan {

Copy link
Contributor

@gui1117 gui1117 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, no need for migration indeed as name is same as previously hardcoded pallet prefix in decl_storage.

@shawntabrizi shawntabrizi added B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit. labels May 19, 2021
@shawntabrizi
Copy link
Member

bot merge

@ghost
Copy link

ghost commented May 19, 2021

Trying merge.

@ghost ghost merged commit 5631239 into paritytech:master May 19, 2021
@KiChjang KiChjang mentioned this pull request May 23, 2021
9 tasks
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants