Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Update slots pallet to FRAME v2 #3218

Merged
3 commits merged into from
Jul 22, 2021
Merged

Conversation

shaunxw
Copy link
Contributor

@shaunxw shaunxw commented Jun 12, 2021

Part of #2882

Converts the Slots pallet to the new pallet attribute macro introduced in #6877.

Following the upgrade guidelines here: https://crates.parity.io/frame_support/attr.pallet.html#upgrade-guidelines.

⚠️ Breaking Change ⚠️

From https://crates.parity.io/frame_support/attr.pallet.html#checking-upgrade-guidelines

storages now use PalletInfo for module_prefix instead of the one given to decl_storage: Thus any use of this pallet in construct_runtime! should be careful to update name in order not to break storage or to upgrade storage (moreover for instantiable pallet). If pallet is published, make sure to warn about this breaking change.

So users of the Slots pallet must be careful about the name they used in construct_runtime!. Hence the runtime-migration label, which might not be needed depending on the configuration of the Slots pallet.

Copy link
Member

@shawntabrizi shawntabrizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@shawntabrizi shawntabrizi added B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit. labels Jun 12, 2021
@shawntabrizi shawntabrizi mentioned this pull request Jun 12, 2021
9 tasks
@emostov emostov self-requested a review July 21, 2021 22:30
@shawntabrizi shawntabrizi added E0-runtime_migration PR introduces code that might require downstream chains to run a runtime upgrade. E5-breaksapi labels Jul 22, 2021
@gui1117
Copy link
Contributor

gui1117 commented Jul 22, 2021

bot merge

@ghost
Copy link

ghost commented Jul 22, 2021

Trying merge.

@ghost ghost merged commit a1d1b7e into paritytech:master Jul 22, 2021
ordian added a commit that referenced this pull request Jul 23, 2021
* master:
  Reduce staking miner reward (companion `substrate/pull/9395`) (#3465)
  Parachains shared.rs to Frame V2 (#3425)
  Parachains hrmp.rs to Frame V2 (#3475)
  Migrate slots pallet to pallet attribute macro. (#3218)
  Improve test in bridge (#3507)
  parachain dmp.rs to Frame V2 (#3426)
  Parachains inclusion.rs to Frame V2 (#3440)
  Dispute coordinator - Recover disputes on startup (#3481)
  Use correct syntax for owning all files in a folder (#3510)
  Add wococo-local chain spec (#3509)
  Dispute vote filtering for block authors (#3498)
  Bump indexmap from 1.6.1 to 1.7.0 (#3497)
  Companion for substrate #9315 (#3477)
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit. E0-runtime_migration PR introduces code that might require downstream chains to run a runtime upgrade.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants