This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Warn on low connectivity. #3408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eskimor
added
A2-insubstantial
bkchr
reviewed
Jul 5, 2021
| /// First time we did not reach our connectivity treshold. | ||
| /// | ||
| /// Will be cleared once we reached it. | ||
| first_failure: Option<Instant>, |
There was a problem hiding this comment.
I don't understand the reason for this value. Especially as you reset it below, meaning this isn't always the first failure.
Wouldn't just a start: Instant be enough to check that we are above the threshold and start with the printing of the warning?
There was a problem hiding this comment.
first failure in a sequence of failures. So the first time we did not connect to enough validators of potentially many attempts. This is most important at startup, but I kept it more generic: Whenever we are not connected to at least 2/3rds of all validators for at least a minute, a warning is printed. I'll clarify the comment.
bkchr
reviewed
Jul 5, 2021
ordian
approved these changes
Jul 5, 2021
drahnr
reviewed
Jul 5, 2021
ordian
added a commit
that referenced
this pull request
Jul 6, 2021
* master: (33 commits) Update all weights, add run_all_benches.sh script (#3400) Enable over-bridge-messaging in Rococo/Wococo runtime (#3377) paras.rs to FRAME V2 (#3403) Add XCM Tracing (#3353) Use MaxEncodedLen trait from new parity-scale-codec v2.2 (#3412) bump a bunch of deps in parity-common (#3402) Warn on low connectivity. (#3408) origin to frame v2 (#3405) Enable logging in the puppet worker (#3411) make it easier to dbg stalls (#3351) XCM `canonicalize` + `prepend_with` fix (#3269) cleanup stream polls (#3397) Staking Miner (#3141) Companion for Substrate#8953 (#3140) Bump version, specs & substrate in prep for v0.9.8 (#3387) Fix busy loops. (#3392) Minor refactor (#3386) add simnet tests (#3381) BEEFY: adjust gossip (#3372) Companion for #9193 (#3376) ...
eskimor
added a commit
that referenced
this pull request
Aug 18, 2021
* Warn on low connectivity. * Better timeout and docs. * Review remarks.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Low connectivity between validators is an issue one should be aware of.