Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Parachains configuration.rs FrameV2 #3516

Merged
10 commits merged into from
Jul 28, 2021
Merged

Parachains configuration.rs FrameV2 #3516

10 commits merged into from
Jul 28, 2021

Conversation

ferrell-code
Copy link
Contributor

@ferrell-code ferrell-code commented Jul 23, 2021 •
edited
Loading

relates: #2882

Following the upgrade guidelines here: https://crates.parity.io/frame_support/attr.pallet.html#upgrade-guidelines.

⚠️ Breaking Change ⚠️

From https://crates.parity.io/frame_support/attr.pallet.html#checking-upgrade-guidelines

storages now use PalletInfo for module_prefix instead of the one given to decl_storage: Thus any use of this pallet in construct_runtime! should be careful to update name in order not to break storage or to upgrade storage (moreover for instantiable pallet). If pallet is published, make sure to warn about this breaking change.

So users of the Configuration pallet must be careful about the name they used in construct_runtime!. Hence the runtime-migration label, which might not be needed depending on the configuration of the Configuration pallet.

kusama, westend and rococo uses ParachainsConfiguration in construct_runtime!, so I migrated them to Configuration

polkadot does not use Configuration.

@ferrell-code ferrell-code changed the title Fer configuration framev2 Parachains configuration.rs framev2 Jul 23, 2021
@ferrell-code ferrell-code changed the title Parachains configuration.rs framev2 Parachains configuration.rs Framev2 Jul 23, 2021
@ferrell-code ferrell-code changed the title Parachains configuration.rs Framev2 Parachains configuration.rs FrameV2 Jul 23, 2021
@shawntabrizi shawntabrizi added B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit. labels Jul 24, 2021
KiChjang
KiChjang approved these changes Jul 28, 2021
View reviewed changes
Copy link
Contributor

@KiChjang KiChjang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work as always!

@KiChjang
Copy link
Contributor

bot merge

@ghost
Copy link

ghost commented Jul 28, 2021

Waiting for commit status.

@ghost ghost merged commit 635f045 into paritytech:master Jul 28, 2021
@ferrell-code ferrell-code deleted the fer-configuration-framev2 branch July 28, 2021 04:58
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@shawntabrizi shawntabrizi shawntabrizi approved these changes

@KiChjang KiChjang KiChjang approved these changes

Assignees
No one assigned
Labels
B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ferrell-code @KiChjang @shawntabrizi