Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Change pallet naming in test-runtime #3551

Merged
3 commits merged into from
Aug 2, 2021
Merged

Change pallet naming in test-runtime #3551

3 commits merged into from
Aug 2, 2021

Conversation

bkchr
Copy link
Member

@bkchr bkchr commented Aug 2, 2021

This is required to make the well_know_keys::ACTIVE_CONFIG match the
ActiveConfig key.

This is required to make the `well_know_keys::ACTIVE_CONFIG` match the
`ActiveConfig` key.
@bkchr bkchr added B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit. labels Aug 2, 2021
@bkchr bkchr requested a review from pepyakin August 2, 2021 09:50
@bkchr bkchr added the A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). label Aug 2, 2021
@pepyakin
Copy link
Contributor

pepyakin commented Aug 2, 2021

Oh, I am not familiar with this integrity_test, I will look into the docs. But you are aware that there is a test for that in this module?

@bkchr
Copy link
Member Author

bkchr commented Aug 2, 2021

Yeah I know and that didn't catch this :P

We changed this to FRAME V2 and this means the prefix of the storage item is derived from the name of the pallet in the runtime. So, the prefix isn't static anymore.

The integrity_test basically boils down to some test that is generated in the runtime to check for certain stuff.

@pepyakin
Copy link
Contributor

pepyakin commented Aug 2, 2021

Meaning that this replaces the existing test? If so, could you please remove it? Or is it still valuable?

@bkchr
Copy link
Member Author

bkchr commented Aug 2, 2021

It still tests if the stuff decodes and contains the expected values. I would still see this somewhat useful.

@bkchr
Copy link
Member Author

bkchr commented Aug 2, 2021

But I also can remove it.

@bkchr
Copy link
Member Author

bkchr commented Aug 2, 2021

(It still ensures that the type of ActiveConfig doesn't change)

@shawntabrizi
Copy link
Member

I talked to @pepyakin yesterday about this, and mentioned it would make sense to me for this to be a custom key from end to end, rather than a pallet storage item (which can be changed from frame version to frame version)

@bkchr
Copy link
Member Author

bkchr commented Aug 2, 2021

I talked to @pepyakin yesterday about this, and mentioned it would make sense to me for this to be a custom key from end to end, rather than a pallet storage item (which can be changed from frame version to frame version)

I'm clearly not happy with the status, but it is the easiest solution for now. In the future we really need to have some better utility for parachains to make use of this. As outlined here paritytech/polkadot-sdk#82 by @pepyakin

@bkchr
Copy link
Member Author

bkchr commented Aug 2, 2021

bot merge

@ghost
Copy link

ghost commented Aug 2, 2021

Waiting for commit status.

@ghost ghost merged commit a52dca2 into master Aug 2, 2021
@ghost ghost deleted the bkchr-use-correct-naming branch August 2, 2021 10:54
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants