This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
New Github Workflow to check extrinsic ordering #3620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chevdor
added
A2-insubstantial
|
A sample run and output can be see here. |
s3krit
approved these changes
Aug 11, 2021
|
Here is the link for the sake of documentation, since it only shows up otherwise in the release todo when a release is being baked. |
chevdor
added a commit
to chevdor/polkadot
that referenced
this pull request
Aug 11, 2021
* ci: new workflow for exrtinsic ordering checks from bin * fix workflow * sanitize output and show result * add context to the output * Add default url * fix envs * fix output generation * Fix the release todos with a link to the gha * fix typo
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes checking for extrinsic ordering easier by introducing a new Github Workflow that runs the steps required to produce a small report comparing the new runtime metadata and the current one.
Since it follows the steps previously mentioned in the release todos, the explanation there has been replaced by a simple call of the workflow.
The new workflow is called manually for now, mainly due to the need for inputs such a link to a built binary.