Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

chore: update builder image #3884

Merged
merged 9 commits into from
Oct 4, 2021
Merged

chore: update builder image #3884

merged 9 commits into from
Oct 4, 2021

Conversation

chevdor
Copy link
Contributor

@chevdor chevdor commented Sep 17, 2021

This PR refreshes the multistage builder Docker image and aligns it with the injected parity image.

⚠️ BREAKING: This image introduces a breaking change to align with the injected image behavior: polkadot is now the entrypoint. So the image is no longer used as docker run -it <image> polkadot --version but as docker run -it <image> --version (the binary polkadot should not longer be provided).

  • add metadata
  • use ubuntu:20.04 as base
  • add label io.parity.image.type="builder"
  • remove labels not relevant to images not built via CI
  • align the entrypoint with the injected image
  • align the volumes with the injected image
  • fix exposed ports
  • rename to a more specific dockerfile name

fix #9765

@chevdor chevdor added A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit. labels Sep 17, 2021
@chevdor chevdor marked this pull request as ready for review September 17, 2021 15:33
Copy link
Contributor

@TriplEight TriplEight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CC another container chore at the same time #3880

docker/polkadot_builder.Dockerfile Outdated Show resolved Hide resolved
docker/docker-compose-local.yml Outdated Show resolved Hide resolved
docker/docker-compose-local.yml Outdated Show resolved Hide resolved
Co-authored-by: Denis Pisarev <denis.pisarev@parity.io>
@chevdor chevdor merged commit 4870e7b into master Oct 4, 2021
@chevdor chevdor deleted the wk-docker-9765 branch October 4, 2021 16:09
ordian added a commit that referenced this pull request Oct 4, 2021
* master:
  chore: update `builder` image (#3884)
  Free disputed cores before processing bitfields (#4008)
  Make candidate validation timeouts configurable (#4001)
ordian added a commit that referenced this pull request Oct 5, 2021
* master: (138 commits)
  Allow an Offset to Lease Periods (#3980)
  Bump quote from 1.0.9 to 1.0.10 (#4013)
  Companion for #9834 (Transaction Priority) (#3901)
  chore: update `builder` image (#3884)
  Free disputed cores before processing bitfields (#4008)
  Make candidate validation timeouts configurable (#4001)
  Add extrinsic ordering filtering (#3631)
  chore: ci list files that spellcheck finds (#3992)
  Use background tasks properly in candidate-validation (#4002)
  Fix unoccupied bitfields (#4004)
  Bump syn from 1.0.77 to 1.0.78 (#4006)
  Bump jsonrpsee-ws-client from 0.3.0 to 0.3.1 (#3931)
  fix clock drift for assignments issued before the block (#3851)
  Remove unoccupied bit check (#3999)
  bump substrate (#4000)
  change genesis authority set for wococo-local, revert rococo-local (#3998)
  ignore irrelevant approvals in logs (#3859)
  avoid expect, on free availability core (#3994)
  preserve finalized block in active leaves (#3997)
  some tweaks to rococo-local (#3996)
  ...
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants