This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Companion for substrate#9732 #4104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cheme
added
B7-runtimenoteworthy
C1-low
gui1117
reviewed
Oct 21, 2021
| @@ -19,7 +19,7 @@ | |||
| use hash_db::{HashDB, Hasher, EMPTY_PREFIX}; | |||
| use sp_runtime::RuntimeDebug; | |||
| use sp_std::vec::Vec; | |||
| use sp_trie::{read_trie_value, Layout, MemoryDB, StorageProof}; | |||
| use sp_trie::{read_trie_value, LayoutV1 as Layout, MemoryDB, StorageProof}; | |||
There was a problem hiding this comment.
it seems we use the Layout only for reading in this file, so V1 or V0 shouldn't matter isn't it ?
I kind of prefer using LayoutV1 explicitly and add a comment on top of its usage saying that v0 and v1 doesn't matter here, also I don't really know about bridge storage proof.
There was a problem hiding this comment.
Yes that is the logic, will switch it.
|
Waiting for commit status. |
ordian
added a commit
that referenced
this pull request
Dec 27, 2021
* master: make check-dependent-* only be executed in PRs (#4588) session_info: add dispute_period and random_seed (#4547) session-info: add new fields + migration (#4545) Bump zstd from 0.9.0+zstd.1.5.0 to 0.9.1+zstd.1.5.1 (#4597) Relaunch Rococo (#4577) Companion for substrate#9732 (#4104) Better logs and metrics on PoV fetching. (#4593)
drahnr
pushed a commit
that referenced
this pull request
Jan 4, 2022
* merge master (do not compile) * fix * lock * update lock * Update to refactoring. * runtime version * fmt * remove trie patch * remove patch * No layout alias for bridge proof. * update depupdate depss * No switch until migration. * master lock * test * test * Revert "test" This reverts commit 57325ef. * Revert "test" This reverts commit ce74d0e. * rename feature * state version as parameter, use the feature only on runtimes. * update * update to state version in runtime * state version from storage * update lockfile for substrate Co-authored-by: parity-processbot <>
Wizdave97
pushed a commit
to ComposableFi/polkadot
that referenced
this pull request
Feb 3, 2022
* merge master (do not compile) * fix * lock * update lock * Update to refactoring. * runtime version * fmt * remove trie patch * remove patch * No layout alias for bridge proof. * update depupdate depss * No switch until migration. * master lock * test * test * Revert "test" This reverts commit 57325ef. * Revert "test" This reverts commit ce74d0e. * rename feature * state version as parameter, use the feature only on runtimes. * update * update to state version in runtime * state version from storage * update lockfile for substrate Co-authored-by: parity-processbot <>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Companion for paritytech/substrate#9732
cumulus companion: paritytech/cumulus#678