This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Introduce prechecking into the configuration runtime #4177
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
A3-in_progress
slumber
added
the
E0-runtime_migration
|
/benchmark runtime westend runtime_parachains::configuration |
pepyakin
reviewed
Nov 2, 2021
| @@ -77,6 +77,20 @@ pub struct HostConfiguration<BlockNumber> { | |||
| /// The delay, in blocks, before a validation upgrade is applied. | |||
| pub validation_upgrade_delay: BlockNumber, | |||
|
|
|||
| // TODO: Which section do these belong to? | |||
There was a problem hiding this comment.
I think we do not need to expose those to the parachains, at least not yet.
The closest is the pvf_upgrade_delay, but the idea is that parachains will look at the go-ahead signal anyway for synchronizing of the upgrades, so it is not needed as well.
|
I am going to take over this issue: will modify the pre-checking paras code and then extract it into a separate PR. Closing this. |
pepyakin
added a commit
that referenced
this pull request
Nov 30, 2021
This PR is a part of #3211. This PR adds three new fields into the `HostConfiguration` structure. The fields are going to be used in PRs down the stack. This change requires migration, so this PR performs runtime storage migration for configuration module from version 1 to version 2. This PR closes #4010 and subsumes #4177. There are several TODOs: - [ ] Fill in the PR number for the reference in migration code - [ ] Decide what weight use for `set_pvf_checking_enabled`. It seems that u32 will be close enough, but maybe we still want to add weight for boolean parameters - [ ] Test the upgrade.
3 tasks
pepyakin
added a commit
that referenced
this pull request
Nov 30, 2021
This PR is a part of #3211. This PR adds three new fields into the `HostConfiguration` structure. The fields are going to be used in PRs down the stack. This change requires migration, so this PR performs runtime storage migration for configuration module from version 1 to version 2. This PR closes #4010 and subsumes #4177. There are several TODOs: - [ ] Fill in the PR number for the reference in migration code - [ ] Decide what weight use for `set_pvf_checking_enabled`. It seems that u32 will be close enough, but maybe we still want to add weight for boolean parameters - [ ] Test the upgrade.
pepyakin
added a commit
that referenced
this pull request
Nov 30, 2021
This PR is a part of #3211. This PR adds three new fields into the `HostConfiguration` structure. The fields are going to be used in PRs down the stack. This change requires migration, so this PR performs runtime storage migration for configuration module from version 1 to version 2. This PR closes #4010 and subsumes #4177. There are several TODOs: - [ ] Fill in the PR number for the reference in migration code - [ ] Decide what weight use for `set_pvf_checking_enabled`. It seems that u32 will be close enough, but maybe we still want to add weight for boolean parameters - [ ] Test the upgrade.
pepyakin
added a commit
that referenced
this pull request
Dec 1, 2021
This PR is a part of #3211. This PR adds three new fields into the `HostConfiguration` structure. The fields are going to be used in PRs down the stack. This change requires migration, so this PR performs runtime storage migration for configuration module from version 1 to version 2. This PR closes #4010 and subsumes #4177. There are several TODOs: - [ ] Fill in the PR number for the reference in migration code - [ ] Decide what weight use for `set_pvf_checking_enabled`. It seems that u32 will be close enough, but maybe we still want to add weight for boolean parameters - [ ] Test the upgrade.
pepyakin
added a commit
that referenced
this pull request
Dec 1, 2021
This PR is a part of #3211. This PR adds three new fields into the `HostConfiguration` structure. The fields are going to be used in PRs down the stack. This change requires migration, so this PR performs runtime storage migration for configuration module from version 1 to version 2. This PR closes #4010 and subsumes #4177.
pepyakin
added a commit
that referenced
this pull request
Dec 3, 2021
This PR is a part of #3211. This PR adds three new fields into the `HostConfiguration` structure. The fields are going to be used in PRs down the stack. This change requires migration, so this PR performs runtime storage migration for configuration module from version 1 to version 2. This PR closes #4010 and subsumes #4177.
pepyakin
added a commit
that referenced
this pull request
Dec 3, 2021
This PR is a part of #3211. This PR adds three new fields into the `HostConfiguration` structure. The fields are going to be used in PRs down the stack. This change requires migration, so this PR performs runtime storage migration for configuration module from version 1 to version 2. This PR closes #4010 and subsumes #4177.
pepyakin
added a commit
that referenced
this pull request
Dec 3, 2021
This PR is a part of #3211. This PR adds three new fields into the `HostConfiguration` structure. The fields are going to be used in PRs down the stack. This change requires migration, so this PR performs runtime storage migration for configuration module from version 1 to version 2. This PR closes #4010 and subsumes #4177.
pepyakin
added a commit
that referenced
this pull request
Dec 3, 2021
This PR is a part of #3211. This PR adds three new fields into the `HostConfiguration` structure. The fields are going to be used in PRs down the stack. This change requires migration, so this PR performs runtime storage migration for configuration module from version 1 to version 2. This PR closes #4010 and subsumes #4177.
pepyakin
added a commit
that referenced
this pull request
Dec 7, 2021
This PR is a part of #3211. This PR adds three new fields into the `HostConfiguration` structure. The fields are going to be used in PRs down the stack. This change requires migration, so this PR performs runtime storage migration for configuration module from version 1 to version 2. This PR closes #4010 and subsumes #4177.
pepyakin
added a commit
that referenced
this pull request
Dec 8, 2021
This PR is a part of #3211. This PR adds three new fields into the `HostConfiguration` structure. The fields are going to be used in PRs down the stack. This change requires migration, so this PR performs runtime storage migration for configuration module from version 1 to version 2. This PR closes #4010 and subsumes #4177.
paritytech-processbot bot
pushed a commit
that referenced
this pull request
Dec 8, 2021
This PR is a part of #3211. This PR adds three new fields into the `HostConfiguration` structure. The fields are going to be used in PRs down the stack. This change requires migration, so this PR performs runtime storage migration for configuration module from version 1 to version 2. This PR closes #4010 and subsumes #4177.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4010