Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

paras: do not allow PVF vote submission if disabled #4684

Merged
merged 1 commit into from
Jan 17, 2022

Commits on Jan 13, 2022

  1. paras: do not allow PVF vote submission if disabled

    if the PVF pre-checking is disabled the runtime dispatchable will reject
    any attempts of submission. This is also concern the unsigned tx
    validation.
    
    Right now, the `include_pvf_check_statement` dispatchable is effectively
    uncallable because of the weight set to the maximum value. If we were to
    benchmark it, it would become includable in a block, but since there
    will be no active votes, the dispatchable won't do anything.
    
    However, it will execute some code, like signature validation and
    querying some storage entries. To be completely safe, we can bail out
    early if the `pvf_checking_enabled` config is disabled. That's what this
    PR does.
    pepyakin committed Jan 13, 2022
    Configuration menu
    Copy the full SHA
    a654a7c View commit details
    Browse the repository at this point in the history