This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Implement a blocking barrier for XCMv3 #5035
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Keith Yeung <kungfukeith11@gmail.com>
…-- benchmark pallet --chain=westend-dev --steps=50 --repeat=20 --pallet=pallet_xcm_benchmarks::generic --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --template=./xcm/pallet-xcm-benchmarks/template.hbs --output=./runtime/westend/src/weights/xcm/pallet_xcm_benchmarks_generic.rs
…-- benchmark pallet --chain=kusama-dev --steps=50 --repeat=20 --pallet=pallet_xcm_benchmarks::generic --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --template=./xcm/pallet-xcm-benchmarks/template.hbs --output=./runtime/kusama/src/weights/xcm/pallet_xcm_benchmarks_generic.rs
KiChjang
commented
Apr 18, 2022
| /// elements returns false, then execution is not suspended. Otherwise, execution is suspended | ||
| /// if any of the tuple elements returns true. | ||
| pub trait CheckSuspension { | ||
| fn is_suspended<Call>( |
There was a problem hiding this comment.
Maybe what should happen here is to put the is_suspended method inside of ShouldExecute, that way we don't need to have a new trait just for this method.
|
Superseded by #6670. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4813.
Introduces a new barrier called
RespectSuspensionwhich takes an inner barrier type and a type that implementsCheckSuspension, which in turn is a trait containing a method namedis_suspendedreturning a boolean to indicate whether we should suspend processing of the incoming XCM.To get this to work,
ShouldExecuteis also modified to return a proper error type calledRejectReason, which is an enum containing all the possible reasons why an XCM did not pass a barrier condition.