Adding Fallback on election failure

[georgesdib]

Companion to paritytech/substrate#10988

Use the newly introduced BoundedOnchainExecution , and UnboundedOnchainExecution for Genesis.

@kianenigma @emostov

[kianenigma]

type Fallback in our production networks should remain NoFallback since we don't quite know what are some good bounds.

As for the GovernanceFallback as well, since this transaction can impose its own limits, I think actually for now we should set it to UnboundedExecution, because we don't know any 'reasonable static bounds' that we can assign to any BoundedExecution type.

The missing step to figure all of this out is to create an accurate weight function for all of this Solver implementations, will make an issue for it.

[georgesdib]

type Fallback in our production networks should remain NoFallback since we don't quite know what are some good bounds.

As for the GovernanceFallback as well, since this transaction can impose its own limits, I think actually for now we should set it to UnboundedExecution, because we don't know any 'reasonable static bounds' that we can assign to any BoundedExecution type.

The missing step to figure all of this out is to create an accurate weight function for all of this Solver implementations, will make an issue for it.

I have reverted the changes including for Westend.

[paritytech-processbot]

Waiting for commit status.

[kianenigma]

@georgesdib thanks for making the bot work with your fork, helps with the automated process.

[paritytech-processbot]

Merge cancelled due to error. Error: Checks failed for e179ded

[kianenigma]

Must look into why and how this caused benchmarks to break.

Alternatively, we can merge this to keep the normal build of master working.

[georgesdib]

Must look into why and how this caused benchmarks to break.

Alternatively, we can merge this to keep the normal build of master working.

You think it's caused by the changes here? I tried to go back in time and see merged PRs from 2 days ago, and they seem to fail the same thing.

An example #5183

#5188 seems to be discussing it as well.

[kianenigma]

hope I am not breaking anything for anyone, merging this manually to keep the master working.