Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

StatementDistributionMessage::get_metadata is a footgun and should be removed #5101

Merged
merged 8 commits into from
Mar 15, 2022
Merged

StatementDistributionMessage::get_metadata is a footgun and should be removed #5101

merged 8 commits into from
Mar 15, 2022

Conversation

Doordashcon
Copy link
Contributor

@Doordashcon Doordashcon commented Mar 14, 2022 •
edited
Loading

This PR attempts to solve #5072

polkadot address: 12zsKEDVcHpKEWb99iFt3xrTCQQXZMu477nJQsTBBrof5k2h

drahnr
drahnr approved these changes Mar 15, 2022
View reviewed changes
Copy link
Contributor

@drahnr drahnr left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides that one last nit, looks good to me 👍 thank you!

@drahnr drahnr added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. labels Mar 15, 2022
@drahnr
Copy link
Contributor

drahnr commented Mar 15, 2022

bot merge

@drahnr
Copy link
Contributor

drahnr commented Mar 15, 2022

/tip small

@paritytech-processbot paritytech-processbot bot merged commit e888a68 into paritytech:master Mar 15, 2022
@substrate-tip-bot
Copy link

A small tip was successfully submitted for Doordashcon (12zsKEDVcHpKEWb99iFt3xrTCQQXZMu477nJQsTBBrof5k2h on polkadot).

https://polkadot.js.org/apps/#/treasury/tips

@Doordashcon
Copy link
Contributor Author

Thanks for the tip :)

@Doordashcon Doordashcon deleted the ddc-GM-T1 branch March 15, 2022 19:27
@Doordashcon Doordashcon mentioned this pull request Sep 29, 2022
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@drahnr drahnr drahnr approved these changes

@rphmeier rphmeier Awaiting requested review from rphmeier

Assignees
No one assigned
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Doordashcon @drahnr @rphmeier