This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
have some lenience on outdated messages in statement distribution #5150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rphmeier
added
A0-please_review
rphmeier
added
B1-releasenotes
and removed
B0-silent
macalicious
approved these changes
Mar 18, 2022
eskimor
approved these changes
Mar 18, 2022
|
bot merge |
|
Waiting for commit status. |
10 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Network-bridge view updates can pre-empt pending messages, leading to many 'out-of-view' notifications in statement-distribution. These cause corresponding network reports, which could exacerbate congestion in the network code.
This alters the statement-distribution code to track some recently outdated heads in the view, and doesn't report peers who are simply sending messages from recently-outdated heads.
This PR is only meant to highlight general approach; I'd be happy for someone to clean it up or do something similar in approval-distribution.