This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Try to fix out of view statements #5177
Merged
+474
−46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drahnr
reviewed
Mar 22, 2022
drahnr
reviewed
Mar 22, 2022
vstakhov
added
B0-silent
drahnr
reviewed
Mar 22, 2022
drahnr
reviewed
Mar 22, 2022
drahnr
reviewed
Mar 22, 2022
drahnr
reviewed
Mar 22, 2022
drahnr
reviewed
Mar 22, 2022
drahnr
reviewed
Mar 22, 2022
drahnr
reviewed
Mar 22, 2022
drahnr
reviewed
Mar 22, 2022
drahnr
reviewed
Mar 22, 2022
drahnr
suggested changes
Mar 22, 2022
There was a problem hiding this comment.
Soundness of the fix checks out.
The test case itself needs attention.
Since modifying the subsystem in it's entirety is not feasible, there are a few things to do:
- add modification functions guarded behind
#[cfg(test)]to modify the internal state as needed - modify
util::choose_random_subsetto consume animpl Rngsuch that in test cases this can be modified as desired
With these changes in place the leading head comment of the test case can be removed in favor of the to be created issue link besides a few more notes inline, where the state is modified with the yet to be created functions.
An alternative approach would be, to not instantiate the full subsystem but only test the incoming messages, and update the view explicitly. The state is too complex though to do so imho.
drahnr
reviewed
Mar 23, 2022
drahnr
reviewed
Mar 23, 2022
drahnr
reviewed
Mar 23, 2022
drahnr
approved these changes
Mar 23, 2022
|
bot merge |
|
Error: Checks failed for 9850839 |
ordian
added a commit
that referenced
this pull request
Mar 24, 2022
* master: Try to fix out of view statements (#5177) Companion for Substrate#11107 (#5197) paras: `include_pvf_check_statement` rt bench (#4938) [ci] Run short benchmarks only in PR pipelines (#5200) Companion for paritytech/substrate#10242 (#4862) [ci] Add short benchmarks to the pipeline (#5188) upgrade coarsetime to 0.1.22 to fix a potential panic (#5193) Update docs and enable DOT-over-XCM (#4809) enable disputes on all chains (#5182) companion for validator self-vote in bags (#5088) Extract MAX_FINALITY_LAG constant from relay_chain_selection (#5159)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This issue happens when some peer sends a good but already known
Secondedstatement and the statement-distribution code does not update thestatements_receivedfield in thepeer_knowledgestructure. Subsequently, aValidstatement causesout-of-viewmessage that is incorrectly emitted and causes reputation lose.