Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Update Block- and Extrinsic base weights #5202

Merged
merged 7 commits into from
Mar 29, 2022

Conversation

ggwpez
Copy link
Member

@ggwpez ggwpez commented Mar 24, 2022

Updates the Block / Extrinsic weights from 5ms / 125ms to [ms]:

  • Polkadot 4.5 / 82.9
  • Kusama 4.17 / 80
  • Westend 3.6 / 72.7
  • Rococo 3.1 / 74.1

These things are important to verify:

  • Uses production profile
  • Uses compiled WASM executor
  • Uses the correct runtime each time
  • Was run on ref hardware (that one is on me 😃)

@coderobe we could update this in each release pipeline after #5137 and paritytech/substrate#11091 are done.
The script will be trivial:

for runtime in "polkadot" "kusama" "westend" "rococo"; do
    ./target/production/polkadot benchmark-overhead --chain=$runtime-dev --execution=wasm --wasm-execution=compiled --weight-path=runtime/$runtime/constants/src/weights/ --warmup=10 --repeat=100
done

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@ggwpez ggwpez added the A3-in_progress Pull request is in progress. No review needed at this stage. label Mar 24, 2022
@github-actions github-actions bot added A0-please_review Pull request needs code review. and removed A3-in_progress Pull request is in progress. No review needed at this stage. labels Mar 24, 2022
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Copy link
Member

@shawntabrizi shawntabrizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome. getting some extra tx per block now :)

@shawntabrizi shawntabrizi added B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit. labels Mar 24, 2022
@ggwpez
Copy link
Member Author

ggwpez commented Mar 24, 2022

Some tests fail that assert that the Block and Ext weight have hard-coded values. Not sure if it still makes sense to have those?
We have the sanity check in the template now. @shawntabrizi
PS: Maybe we can change it to sanity-check the price after the WeightToFee.

ggwpez and others added 4 commits March 25, 2022 12:32
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Copy link
Contributor

@coderobe coderobe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good, i'll look into integrating this into the release pipeline

@ggwpez
Copy link
Member Author

ggwpez commented Mar 29, 2022

bot merge

@paritytech-processbot paritytech-processbot bot merged commit 4719e8a into master Mar 29, 2022
@paritytech-processbot paritytech-processbot bot deleted the oty-update-weights branch March 29, 2022 12:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants