This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Revert approval voting #5438
Merged
Revert approval voting #5438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davxy
added
B0-silent
4 tasks
ordian
reviewed
May 3, 2022
ordian
reviewed
May 3, 2022
skunert
reviewed
May 6, 2022
skunert
approved these changes
May 9, 2022
drahnr
reviewed
May 9, 2022
drahnr
reviewed
May 9, 2022
drahnr
reviewed
May 9, 2022
| (children, children_height) | ||
| }, | ||
| None => { | ||
| let children_height = stored_range.0; |
There was a problem hiding this comment.
nit: We could use a Range<usize> type to make this a bit more natural rather than using a tuple?
There was a problem hiding this comment.
I'm not sure about the suggestion, but the tuple is (Vec, BlockNumber).
I can't use a Range here
There was a problem hiding this comment.
Then I'd use a struct with named fields :)
drahnr
reviewed
May 9, 2022
drahnr
suggested changes
May 9, 2022
drahnr
reviewed
May 10, 2022
drahnr
approved these changes
May 10, 2022
3 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially addresses #5396
This PR is a follow up of #5350 and addresses the revert of the
ApprovalVotingsubsystem.The operation api is similar to the one exposed by the
ChainSelectionsubsystem.No particular blockers were found.