Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

[ci] Run check-runtime only for release branches #5858

Merged
merged 5 commits into from
Aug 11, 2022
Merged

[ci] Run check-runtime only for release branches #5858

merged 5 commits into from
Aug 11, 2022

Conversation

alvicsam
Copy link
Contributor

@alvicsam alvicsam commented Aug 4, 2022

@alvicsam alvicsam requested a review from chevdor August 4, 2022 09:55
@alvicsam alvicsam requested a review from a team as a code owner August 4, 2022 09:55
@github-actions github-actions bot added the A0-please_review Pull request needs code review. label Aug 4, 2022
@paritytech-ci paritytech-ci requested a review from a team August 4, 2022 09:56
@alvicsam alvicsam added B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. labels Aug 4, 2022
@ordian
Copy link
Member

ordian commented Aug 4, 2022

Run check-runtime only for PRs

The issue is about running it only for (PRs to) release branches.

@alvicsam
Copy link
Contributor Author

alvicsam commented Aug 4, 2022

The issue is about running it only for (PRs to) release branches

Good catch, thank you. I added rule release-v* and keep rule for PR because we can't distinguish difference between PR into master or into other branch in gitlab

@ordian
Copy link
Member

ordian commented Aug 4, 2022 •
edited
Loading

The issue is about running it only for (PRs to) release branches

Good catch, thank you. I added rule release-v* and keep rule for PR because we can't distinguish difference between PR into master or into other branch in gitlab

Can we use something like CI_MERGE_REQUEST_TARGET_BRANCH_NAME? The purpose of the issue is to remove this check for PRs into master (on github) and currently this PR doesn't do it.

@alvicsam
Copy link
Contributor Author

alvicsam commented Aug 4, 2022

Hm, the issue has this text:

It would be good to keep this check but remove it from master and ensure it runs in the release branches

The PR removes the check-runtime from master and runs it on release branches.

@ordian you mentioned that it also should run in PRs to release branches. We mirror Github branches to Gitlab with custom solution and all PRs are mirrored as branches with PR number. So currently there is no way to run the check-runtime job only for PRs into release branches. I can either disable it for PRs at all or keep for all PRs.

@ordian
Copy link
Member

ordian commented Aug 4, 2022

Well, if we can't distinguish between PRs to master or a release branch, not sure if this check is useful at all. IIRC, it was introduced so that we bump the spec version when needed, but only when needed on master. But now we have a release process that bumps the version on every release. So what value does this check bring? Maybe we should remove it? @bkchr

@bkchr
Copy link
Member

bkchr commented Aug 4, 2022

Maybe we should remove it?

From my side we can remove it. I mean there should be no need anymore

@alvicsam
Copy link
Contributor Author

alvicsam commented Aug 4, 2022

@chevdor wdyt? do you need it for release-v* branches?

@ordian ordian mentioned this pull request Aug 4, 2022
Closed
@chevdor
Copy link
Contributor

chevdor commented Aug 5, 2022

@chevdor wdyt? do you need it for release-v* branches?

any release branch yes

@alvicsam alvicsam merged commit edf5df5 into master Aug 11, 2022
@alvicsam alvicsam deleted the as-disable-check-runtime branch August 11, 2022 13:23
@ordian ordian changed the title [ci] Run check-runtime only for PRs [ci] Run check-runtime only for release branches Aug 11, 2022
ordian added a commit that referenced this pull request Aug 15, 2022
@ordian
Merge branch 'master' into ao-disputes-rewards
5665053 
* master:
  Transaction payment runtime apis: query call info and fee details (#5871)
  [ci] Improve cancel-pipeline job (#5874)
  Bump wasmtime from 0.38.1 to 0.38.3 (#5802)
  Incorporate changes from substrate PR #11908 (#5815)
  Add nomination pools to Polkadot runtime (#5582)
  Change request-response protocol names to include genesis hash & fork id (#5870)
  [ci] Run check-runtime only for PRs (#5858)
  Bump tokio from 1.18.2 to 1.19.2 (#5678)
  Zombienet: test disputes with malus garbage candidates (#5857)
  add unit tests to run runtime migrations (#5865)
  Trivial networking changes for Substrate PR #11940 (#5841)
  Renaming CLI prunning and keep-blocks flags (#5863)
  Update yamux to fix a potential crash (#5861)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@chevdor chevdor chevdor approved these changes

@coderobe coderobe coderobe approved these changes

@radupopa2010 radupopa2010 radupopa2010 approved these changes

@sergejparity sergejparity sergejparity approved these changes

Assignees
No one assigned
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@alvicsam @ordian @bkchr @chevdor @coderobe @radupopa2010 @sergejparity