Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

More generic extrinsic pool #6

Merged
merged 1 commit into from
Aug 29, 2018
Merged

More generic extrinsic pool #6

merged 1 commit into from
Aug 29, 2018

Conversation

arkpar
Copy link
Member

@arkpar arkpar commented Aug 20, 2018

Follows substrate changes in paritytech/substrate#579

@arkpar arkpar added the A0-please_review Pull request needs code review. label Aug 20, 2018
@arkpar arkpar closed this Aug 23, 2018
@arkpar arkpar reopened this Aug 23, 2018
Copy link
Contributor

@tomusdrw tomusdrw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

let encoded = uxt.encode();
let encoded_size = encoded.len();

let (encoded_size, hash) = (encoded.len(), BlakeTwo256::hash(&encoded));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Previously we were avoiding hashing if it was too large, but I guess it's not an issue.

@arkpar arkpar merged commit 293af33 into master Aug 29, 2018
@arkpar arkpar deleted the a-ext-pool branch August 29, 2018 10:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-please_review Pull request needs code review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants