dispute-coordinator: past session dispute slashing #6811

ordian · 2023-03-02T17:38:29Z

Closes #5947.

On top of #6667.

TODO:

Prettify
Fix tests
Zombienet test
Investigate WARN tokio-runtime-worker txpool::api: (offchain call) Error submitting a transaction to the pool: Transaction pool error: Invalid transaction validity: InvalidTransaction::ExhaustsResources
Investigate panic in debug assertion
Fix zombienet test (blocked on zndsl: support subtracting metrics zombienet#1044)

Co-authored-by: Marcin S. <marcin@bytedude.com>

node/core/dispute-coordinator/src/scraping/mod.rs

* master: (27 commits) bump `zombienet` version to v1.3.37 (#6773) Bump `blake2b_simd` to 1.0.1 (#6829) changelog: update template for new label behavior (E3/E4) (#6804) Companion for paritytech/substrate#12828 (#6380) Don't send `ActiveLeaves` from leaves in db on startup in Overseer (#6727) Polkadot XCM Body constants (#6788) Decrease expected peer count in zombinenet tests (#6826) Additional tracing in `provisioner`, `vote_selection` and `dispute-coordinator` (#6775) Change node-key for bootnodes (#6772) Change handle_import_statements to FatalResult (#6820) Introduce XCM matcher for writing barriers (#6756) Freeze note on `SessionInfo`. (#6818) Bump parity-db (#6816) Removing Outdated References to Misbehavior Arbitration Subsystem (#6814) Forgotten re-export for `MatchedConvertedConcreteId` (#6815) Companion for substrate#13509: bump API versions of {Beefy,Mmr}Api (#6809) Migrate to `Weight::from_parts` (#6794) [XCM] Multiple `FungiblesAdapter`s support + `WeightTrader::buy_weight` more accurate error (#6739) Get rid of unnecessary cloning and work. (#6808) changelog: fix migration listing (#6806) ...

…slashing-client * ao-past-session-slashing-runtime:

node/core/dispute-coordinator/src/initialized.rs

tdimitrov

Great work @ordian 💯

* master: PVF: instantiate runtime from bytes (#7270)

* master: [companion] Fix request-response protocols backpressure mechanism (#7276)

* master: XCM: Tools for uniquely referencing messages (#7234) Companion: Substrate#13869 (#7119) Companion for Substrate#14214 (#7283) Fix flaky test and error reporting (#7282) impl guide: Update Collator Generation (#7250) Add staking-miner bin (#7273) metrics: tests: Fix flaky runtime_can_publish_metrics (#7279)

…slashing-client * ao-past-session-slashing-runtime: XCM: Tools for uniquely referencing messages (#7234) Companion: Substrate#13869 (#7119) Companion for Substrate#14214 (#7283) Fix flaky test and error reporting (#7282) impl guide: Update Collator Generation (#7250) Add staking-miner bin (#7273) metrics: tests: Fix flaky runtime_can_publish_metrics (#7279) [companion] Fix request-response protocols backpressure mechanism (#7276) PVF: instantiate runtime from bytes (#7270)

* master: bump zombienet version (#7292) xcm-builder: remove clone for clippy (#7291)

…slashing-client * ao-past-session-slashing-runtime: bump zombienet version (#7292) xcm-builder: remove clone for clippy (#7291)

* master: runtime: past session slashing runtime API (#6667) cli: enable BEEFY by default on test networks (#7293) pallets: implement `Default` for `GenesisConfig` in `no_std` (#7271) Update quote to 1.0.27 (#7280) PVF: Refactor workers into separate crates, remove host dependency (#7253)

ordian · 2023-05-26T13:58:07Z

@paritytech/ci @paritytech/release-engineering @chevdor an approval please 🙏
@eskimor a review please 🙏 🙏 🙏

eskimor · 2023-05-26T21:05:33Z

node/core/dispute-coordinator/src/initialized.rs

+				"Processing unapplied validator slashes",
+			);
+
+			let inclusions = self.scraper.get_blocks_including_candidate(&candidate_hash);


We only keep that information for the unfinalized chain (and a bit more). Is that enough for this purpose?

Good point. For the scraped included blocks this is fine. If we finalized a different block at the same height, that probably means the dispute has concluded before, so we should have called this already on some block producing node and DISPUTE_CANDIDATE_LIFETIME_AFTER_FINALIZATION helps with this race condition.

There's a potential problem with runtime API calls to key_ownership_proof though since this block will be pruned once we reorg to and finalize the undisputed chain. But again, there's a time window between dispute concluding and that happening, so we should be able to slash with some high probability in that case.

I am uneasy about this. The raciness for participation already bothers me, but here it is even worse. I am not blocking this PR on this, as racy past session slashing is better than no past session slashing, but let's discuss this further.

eskimor · 2023-06-05T16:35:38Z

@the-right-joyce worth mentioning this does not yet enable past session slashes on Kusama or Polkadot, only Westend and Rococo.

ordian · 2023-06-06T05:54:08Z

Yes, enabling it is easy though: we need to implement v5 of ParachainHost and do the runtime upgrade:

polkadot/runtime/westend/src/lib.rs

Line 1477 in cf0ecdd

#[api_version(5)]

polkadot/runtime/kusama/src/lib.rs

Line 1720 in cf0ecdd

    
           impl primitives::runtime_api::ParachainHost<Block, Hash, BlockNumber> for Runtime {

eskimor · 2023-06-07T14:10:15Z

Working on making this available on Polkadot and Kusama. Versioning was a bit messed up in places, fixing. @ordian was this tested with a runtime not yet supporting the calls? Seems we just debug log any error anyway.

ordian · 2023-06-07T14:23:43Z

Ouch, I think I tested it before #6885 was merged, but yeah, the only trouble is we will get a different type of error in debug logs. These requirements need to be bumped to 5 to fix that indeed.

eskimor · 2023-06-07T14:24:47Z

Ouch, I think I tested it before #6885 was merged, but yeah, the only trouble is we will get a different type of error in debug logs. These requirements need to be bumped to 5 to fix that indeed.

Already on it.

eskimor · 2023-06-07T22:10:31Z

#7341

ordian and others added 9 commits February 3, 2023 10:18

runtime/vstaging: unapplied_slashes runtime API

8dbeae7

runtime/vstaging: key_ownership_proof runtime API

d3273d7

runtime/ParachainHost: submit_report_dispute_lost

8394592

fix key_ownership_proof API

d31edbb

runtime: submit_report_dispute_lost runtime API

5808d0b

nits

78d9da0

Update node/subsystem-types/src/messages.rs

7caf651

Co-authored-by: Marcin S. <marcin@bytedude.com>

merge master and resolve ExecutorParams conflicts

ab08d67

revert unrelated fmt changes

62e3831

dispute-coordinator: past session dispute slashing

5223ef3

ordian force-pushed the ao-past-session-slashing-client branch from 7689006 to 5223ef3 Compare March 2, 2023 17:41

ordian added 3 commits March 5, 2023 19:32

encapsule runtime api call for submitting report

af6921d

prettify: extract into a function

9d4e21f

do not exit on runtime api error

39def6a

ordian commented Mar 6, 2023

View reviewed changes

node/core/dispute-coordinator/src/scraping/mod.rs Show resolved Hide resolved

ordian added 10 commits March 7, 2023 12:51

fix tests

1495b47

Merge branch 'ao-past-session-slashing-runtime' into ao-past-session-…

a062b6c

…slashing-client * ao-past-session-slashing-runtime:

try initial zombienet test

eca1786

try something

13b6271

fix a typo

77ec15a

try cumulus-based collator

49cb564

fix clippy

288696e

build polkadot-debug images with fast-runtime enabled

36d60d9

tdimitrov reviewed May 23, 2023

View reviewed changes

node/core/dispute-coordinator/src/initialized.rs Show resolved Hide resolved

tdimitrov approved these changes May 23, 2023

View reviewed changes

ordian added 7 commits May 24, 2023 11:00

add a comment and search logs on all nodes

cfe4be4

Merge branch 'master' into ao-past-session-slashing-runtime

9cb0723

* master: PVF: instantiate runtime from bytes (#7270)

Merge branch 'master' into ao-past-session-slashing-runtime

1ae22c5

* master: [companion] Fix request-response protocols backpressure mechanism (#7276)

Merge branch 'master' into ao-past-session-slashing-runtime

f621e4a

* master: bump zombienet version (#7292) xcm-builder: remove clone for clippy (#7291)

Merge branch 'ao-past-session-slashing-runtime' into ao-past-session-…

92c5228

…slashing-client * ao-past-session-slashing-runtime: bump zombienet version (#7292) xcm-builder: remove clone for clippy (#7291)

Base automatically changed from ao-past-session-slashing-runtime to master May 26, 2023 09:35

eskimor reviewed May 26, 2023

View reviewed changes

eskimor approved these changes May 30, 2023

View reviewed changes

eskimor mentioned this pull request Aug 24, 2023

Figure out raciness of past session slashing paritytech/polkadot-sdk#623

Closed

eskimor requested a review from coderobe May 31, 2023 14:55

coderobe approved these changes May 31, 2023

View reviewed changes

paritytech-ci requested a review from a team May 31, 2023 18:33

pepoviola approved these changes Jun 5, 2023

View reviewed changes

altaua approved these changes Jun 5, 2023

View reviewed changes

eskimor merged commit cab7ae5 into master Jun 5, 2023

eskimor deleted the ao-past-session-slashing-client branch June 5, 2023 16:21

crystalin mentioned this pull request Oct 20, 2023

Update substrate/polkadot/cumulus from v0.9.43 to v1.1.0 moonbeam-foundation/moonbeam#2535

Closed

JesseAbram mentioned this pull request Oct 26, 2023

Update substrate and subxt entropyxyz/entropy-core#435

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

dispute-coordinator: past session dispute slashing #6811

dispute-coordinator: past session dispute slashing #6811

ordian commented Mar 2, 2023 •

edited

Loading

tdimitrov left a comment •

edited

Loading

ordian commented May 26, 2023 •

edited

Loading

eskimor May 26, 2023

ordian May 27, 2023 •

edited

Loading

eskimor May 30, 2023 •

edited

Loading

eskimor commented Jun 5, 2023

ordian commented Jun 6, 2023

eskimor commented Jun 7, 2023 •

edited

Loading

ordian commented Jun 7, 2023

eskimor commented Jun 7, 2023

eskimor commented Jun 7, 2023

dispute-coordinator: past session dispute slashing #6811

dispute-coordinator: past session dispute slashing #6811

Conversation

ordian commented Mar 2, 2023 • edited Loading

tdimitrov left a comment • edited Loading

Choose a reason for hiding this comment

ordian commented May 26, 2023 • edited Loading

eskimor May 26, 2023

Choose a reason for hiding this comment

ordian May 27, 2023 • edited Loading

Choose a reason for hiding this comment

eskimor May 30, 2023 • edited Loading

Choose a reason for hiding this comment

eskimor commented Jun 5, 2023

ordian commented Jun 6, 2023

eskimor commented Jun 7, 2023 • edited Loading

ordian commented Jun 7, 2023

eskimor commented Jun 7, 2023

eskimor commented Jun 7, 2023

ordian commented Mar 2, 2023 •

edited

Loading

tdimitrov left a comment •

edited

Loading

ordian commented May 26, 2023 •

edited

Loading

ordian May 27, 2023 •

edited

Loading

eskimor May 30, 2023 •

edited

Loading

eskimor commented Jun 7, 2023 •

edited

Loading