Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Add option to skip av-store requests in availability-recovery-subsystem #7131

Merged
merged 4 commits into from
Apr 28, 2023
Merged

Add option to skip av-store requests in availability-recovery-subsystem #7131

merged 4 commits into from
Apr 28, 2023

Conversation

skunert
Copy link
Contributor

@skunert skunert commented Apr 24, 2023

On collators the availability-store subsystem is not running. It is unnecessary to request the av-store there.

@skunert skunert added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit. T4-parachains_engineering This PR/Issue is related to Parachains performance, stability, maintenance. labels Apr 24, 2023
@skunert skunert requested a review from a team April 24, 2023 20:34
@michalkucharczyk michalkucharczyk requested a review from a team April 25, 2023 08:56
skunert and others added 2 commits April 25, 2023 14:48
@skunert @michalkucharczyk
Update node/network/availability-recovery/src/lib.rs
70f480b 
Co-authored-by: Michal Kucharczyk <1728078+michalkucharczyk@users.noreply.github.com>
@skunert
Merge branch 'master' into skunert/skip-availability-store
acbc1b9
@skunert
Copy link
Contributor Author

skunert commented Apr 28, 2023

bot rebase

@paritytech-processbot
Copy link

Error: Command 'Command { std: cd "/storage/repositories/polkadot" && "git" "push" "--porcelain" "skunert" "skunert/skip-availability-store", kill_on_drop: false }' failed with status Some(1); output: remote: Resolving deltas: 0% (0/86)
remote: Resolving deltas: 1% (1/86)
remote: Resolving deltas: 2% (2/86)
remote: Resolving deltas: 3% (3/86)
remote: Resolving deltas: 4% (4/86)
remote: Resolving deltas: 5% (5/86)
remote: Resolving deltas: 6% (6/86)
remote: Resolving deltas: 8% (7/86)
remote: Resolving deltas: 9% (8/86)
remote: Resolving deltas: 10% (9/86)
remote: Resolving deltas: 11% (10/86)
remote: Resolving deltas: 12% (11/86)
remote: Resolving deltas: 13% (12/86)
remote: Resolving deltas: 15% (13/86)
remote: Resolving deltas: 16% (14/86)
remote: Resolving deltas: 17% (15/86)
remote: Resolving deltas: 18% (16/86)
remote: Resolving deltas: 19% (17/86)
remote: Resolving deltas: 20% (18/86)
remote: Resolving deltas: 22% (19/86)
remote: Resolving deltas: 23% (20/86)
remote: Resolving deltas: 24% (21/86)
remote: Resolving deltas: 25% (22/86)
remote: Resolving deltas: 26% (23/86)
remote: Resolving deltas: 27% (24/86)
remote: Resolving deltas: 29% (25/86)
remote: Resolving deltas: 30% (26/86)
remote: Resolving deltas: 31% (27/86)
remote: Resolving deltas: 32% (28/86)
remote: Resolving deltas: 33% (29/86)
remote: Resolving deltas: 34% (30/86)
remote: Resolving deltas: 36% (31/86)
remote: Resolving deltas: 37% (32/86)
remote: Resolving deltas: 38% (33/86)
remote: Resolving deltas: 39% (34/86)
remote: Resolving deltas: 40% (35/86)
remote: Resolving deltas: 41% (36/86)
remote: Resolving deltas: 43% (37/86)
remote: Resolving deltas: 44% (38/86)
remote: Resolving deltas: 45% (39/86)
remote: Resolving deltas: 46% (40/86)
remote: Resolving deltas: 47% (41/86)
remote: Resolving deltas: 48% (42/86)
remote: Resolving deltas: 50% (43/86)
remote: Resolving deltas: 51% (44/86)
remote: Resolving deltas: 52% (45/86)
remote: Resolving deltas: 53% (46/86)
remote: Resolving deltas: 54% (47/86)
remote: Resolving deltas: 55% (48/86)
remote: Resolving deltas: 56% (49/86)
remote: Resolving deltas: 58% (50/86)
remote: Resolving deltas: 59% (51/86)
remote: Resolving deltas: 60% (52/86)
remote: Resolving deltas: 61% (53/86)
remote: Resolving deltas: 62% (54/86)
remote: Resolving deltas: 63% (55/86)
remote: Resolving deltas: 65% (56/86)
remote: Resolving deltas: 66% (57/86)
remote: Resolving deltas: 67% (58/86)
remote: Resolving deltas: 68% (59/86)
remote: Resolving deltas: 69% (60/86)
remote: Resolving deltas: 70% (61/86)
remote: Resolving deltas: 72% (62/86)
remote: Resolving deltas: 73% (63/86)
remote: Resolving deltas: 74% (64/86)
remote: Resolving deltas: 75% (65/86)
remote: Resolving deltas: 76% (66/86)
remote: Resolving deltas: 77% (67/86)
remote: Resolving deltas: 79% (68/86)
remote: Resolving deltas: 80% (69/86)
remote: Resolving deltas: 81% (70/86)
remote: Resolving deltas: 82% (71/86)
remote: Resolving deltas: 83% (72/86)
remote: Resolving deltas: 84% (73/86)
remote: Resolving deltas: 86% (74/86)
remote: Resolving deltas: 87% (75/86)
remote: Resolving deltas: 88% (76/86)
remote: Resolving deltas: 89% (77/86)
remote: Resolving deltas: 90% (78/86)
remote: Resolving deltas: 91% (79/86)
remote: Resolving deltas: 93% (80/86)
remote: Resolving deltas: 94% (81/86)
remote: Resolving deltas: 95% (82/86)
remote: Resolving deltas: 96% (83/86)
remote: Resolving deltas: 97% (84/86)
remote: Resolving deltas: 98% (85/86)
remote: Resolving deltas: 100% (86/86)
remote: Resolving deltas: 100% (86/86), completed with 53 local objects.
error: failed to push some refs to 'https://github.com/skunert/polkadot.git'

@skunert
Copy link
Contributor Author

skunert commented Apr 28, 2023

bot merge

@paritytech-processbot
Copy link

Waiting for commit status.

@paritytech-processbot paritytech-processbot bot merged commit 1d8ccbf into paritytech:master Apr 28, 2023
@skunert skunert mentioned this pull request Apr 29, 2023
Merged
@github-actions github-actions bot mentioned this pull request Jun 15, 2023
Closed
@kiltbot kiltbot mentioned this pull request Jun 21, 2023
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@michalkucharczyk michalkucharczyk michalkucharczyk approved these changes

@bkchr bkchr bkchr approved these changes

Assignees
No one assigned
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit. T4-parachains_engineering This PR/Issue is related to Parachains performance, stability, maintenance.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@skunert @michalkucharczyk @bkchr