Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Companion for #5463 #953

Merged
merged 4 commits into from
Mar 31, 2020
Merged

Companion for #5463 #953

merged 4 commits into from
Mar 31, 2020

Conversation

shawntabrizi
Copy link
Member

This is a companion PR for paritytech/substrate#5463 where the genesis block is set to 0.

@shawntabrizi shawntabrizi added A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). A0-please_review Pull request needs code review. labels Mar 31, 2020
@shawntabrizi shawntabrizi mentioned this pull request Mar 31, 2020
Merged
@bkchr
Copy link
Member

bkchr commented Mar 31, 2020

Please run cargo update -p sp-io and commit the Cargo.lock

@shawntabrizi shawntabrizi added A8-looksgood and removed A0-please_review Pull request needs code review. labels Mar 31, 2020
@shawntabrizi shawntabrizi changed the base branch from master to shawntabrizi-fast-benchmarks March 31, 2020 15:50
@shawntabrizi shawntabrizi merged commit 098292a into shawntabrizi-fast-benchmarks Mar 31, 2020
@shawntabrizi shawntabrizi deleted the shawntabrizi-genesis-block-zero branch March 31, 2020 15:51
gavofyork pushed a commit that referenced this pull request Mar 31, 2020
@shawntabrizi
Companion PR for #5436/#5445 + #5463 (#948)
1311c3d 
* Use `add_benchmark` macro

* Return error if `batches` is empty

* Update Cargo.lock

* Companion for #5463 (#953)

* Fix test with genesis block 0

* Update Cargo.lock
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bkchr bkchr bkchr approved these changes

Assignees
No one assigned
Labels
A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update).
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shawntabrizi @bkchr @paritytech-ci