Remove usage of substrate-test-runtime. #969

expenses · 2020-04-03T13:18:56Z

Closes #946.

…t_test_runtime one

expenses · 2020-04-03T13:33:29Z

@bkchr the tests fail with thread 'block_import::import_single_good_known_block_is_ignored' panicked at 'calledResult::unwrap()on anErr value: Execution(Wasmi(Trap(Trap { kind: Unreachable })))', network/test/src/block_import.rs:30:17.
What should I do to debug this?

bkchr · 2020-04-03T13:35:25Z

runtime/test-runtime/src/genesismap.rs

+use sp_runtime::traits::{Block as BlockT, Hash as HashT, Header as HeaderT};
+
+/// Configuration of a general Substrate test genesis block.
+pub struct GenesisConfig {


Why did you copy all this code? You don't need it.

bkchr · 2020-04-03T13:38:01Z

@bkchr the tests fail with thread 'block_import::import_single_good_known_block_is_ignored' panicked at 'calledResult::unwrap()on anErr value: Execution(Wasmi(Trap(Trap { kind: Unreachable })))', network/test/src/block_import.rs:30:17.
What should I do to debug this?

I don't know what these tests are doing. You probably need to debug them.

rphmeier · 2020-04-03T17:00:29Z

@expenses The test failure is probably related to the stuff we talked about before - that the Parachains module expects the SetHeads inherent, and the test utilities here aren't providing it.

bkchr · 2020-04-04T07:58:02Z

If you set a logger and run with runtime=trace, you will see the panic message of the runtime.

bkchr

Looks good, just some last small fixes ;)

bkchr · 2020-04-08T16:49:53Z

runtime/test-runtime/client/src/lib.rs

+	};
+
+	let timestamp = polkadot_test_runtime::UncheckedExtrinsic {
+		function: polkadot_test_runtime::Call::Timestamp(pallet_timestamp::Call::set(0)),


You should use the correct timestamp here (milliseconds since UNIX epoch).

bkchr · 2020-04-08T16:50:51Z

runtime/test-runtime/client/src/lib.rs

@@ -321,3 +316,20 @@ pub fn new_light_fetcher() -> LightFetcher {
 pub fn new_native_executor() -> sc_executor::NativeExecutor<LocalExecutor> {
 	sc_executor::NativeExecutor::new(sc_executor::WasmExecutionMethod::Interpreted, None, 8)
 }
+
+/// Extrinsics that must be included in each block.
+pub fn needed_extrinsics() -> (polkadot_test_runtime::UncheckedExtrinsic, polkadot_test_runtime::UncheckedExtrinsic) {


I think it would be nice to take the heads as parameter.

And why not just return a Vec? If in the future we add another inherent, we would need to touch every line that uses this function.

bkchr · 2020-04-08T16:51:52Z

runtime/test-runtime/src/genesismap.rs

+		let mut map: BTreeMap<Vec<u8>, Vec<u8>> = self.balances.iter()
+			.map(|&(ref account, balance)| (account.to_keyed_vec(b"balance:"), vec![].and(&balance)))
+			.map(|(k, v)| (blake2_256(&k[..])[..].to_vec(), v.to_vec()))
+			.chain(vec![
+				(well_known_keys::CODE.into(), wasm_runtime),
+				(
+					well_known_keys::HEAP_PAGES.into(),
+					vec![].and(&(self.heap_pages_override.unwrap_or(16 as u64))),
+				),
+			].into_iter())
+			.collect();


This code is not needed.

bkchr · 2020-04-08T16:52:17Z

runtime/test-runtime/src/genesismap.rs

+		// Assimilate the system genesis config.
+		let mut storage = Storage { top: map, children: self.extra_storage.children.clone()};
+		let config = crate::GenesisConfig {
+            system: None,


We should set CODE here in the System genesis config.

expenses · 2020-04-15T15:56:36Z

@bkchr this should be ready for review now.

bkchr · 2020-04-17T15:30:52Z

runtime/test-runtime/src/genesismap.rs

+		// Assimilate the system genesis config.
+		let mut storage = Storage { top: BTreeMap::new(), children: self.extra_storage.children.clone()};
+		let config = crate::GenesisConfig {
+            system: Some(system::GenesisConfig {


bkchr · 2020-04-17T15:30:58Z

runtime/test-runtime/src/genesismap.rs

+            balances: Some(balances::GenesisConfig {
+				balances: self.balances.clone()
+			}),
+            staking: None,


service/src/grandpa_support.rs

Co-Authored-By: Bastian Köcher <bkchr@users.noreply.github.com>

…-extrinsic

runtime/test-runtime/src/genesismap.rs

23dda62 Rococo <> Wococo messages relay (#1030) bcde21d Update the wasm builder to substrate master (#1029) a8318ce Make target signer optional when sending message. (#1018) f8602e1 Fix insufficient balance when send message. (#1020) d95c0a7 greedy relayer don't need message dispatch to be prepaid if dispatch is supposed to be paid at the target chain (#1016) ad5876f Update types. (#1027) 116cbbc CI: fix starting the pipeline (#1022) 7e0fadd Add temporary `canary` job (#1019) 6787091 Update types to contain dispatch_fee_payment (#1017) 03f79ad Allow Root to assume SourceAccount. (#1011) 372d019 Return dispatch_fee_payment from message details RPC (#1014) 604eb1c Relay basic single-bit message dispatch results back to the source chain (#935) bf52fff Use plain source_queue view when selecting nonces for delivery (#1010) fc5cf7d pay dispatch fee at target chain (#911) 1e35477 Bump Substrate to `286d7ce` (#1006) 7ad07b3 Add --only-mandatory-headers mode (#1004) 5351dc9 Messages relayer operating mode (#995) 9bc29a7 Rococo <> Wococo relayer balance guard (#998) bc17341 rename messages_dispatch_weight -> message_details (#996) 95be244 Bump Rococo and Wococo spec versions (#999) c35567b Move ChainWithBalances::NativeBalance -> Chain::Balance (#990) 1bfece1 Fix some nits (#988) 334ea0f Increase pause before starting relays again (#989) 7fb8248 Fix clippy in test code (#993) d60ae50 fix clippy issues (#991) 75ca813 Make sure GRANDPA shares state with RPC. (#987) da2a38a Bump Substrate (#986) 5a9862f Update submit finality proof weight formula (#981) 69df513 Flag for rejecting all outbound messages (#982) 14d0506 Add script to setup bench machine. (#984) e74e8ab Move CI from GitHub Actions to GitLab (#814) c5ca5dd Custom justification verification (#979) 643f10d Always run on-demand headers relay in complex relay (#975) a35b0ef Add JSON type definitions for Rococo<>Wococo bridge (#977) 0eb83f2 Update cargo.deny (#980) e1d1f4c Bump Rococo/Wococo spec_version (#976) deac90d increase pause before starting relays (#974) 68d6d79 Revert to use InspectCmd, bump substrate `6bef4f4` (#966) 66e1508 Avoid hashing headers twice in verify_justification (#973) a31844f Bump `environmental` dependency (#972) 2a4c29a in auto-relays keep trying to connect to nodes until connection is established (#971) 0e767b3 removed stray file (#969) b9545dc Serve multiple lanes with single complex relay instance (#964) 73419f4 Correct type error (#968) bac256f Start finality relay spec-version guards for Rococo <> Wococo finality relays (#965) bfd7037 pass source and target chain ids to account_ownership_proof (#963) 8436073 Upstream changes from Polkadot repo (#961) e58d851 Increase account endowment amount (#960) git-subtree-dir: bridges git-subtree-split: 23dda6248236b27f20d76cbedc30e189cc6f736c

fd24e98 send R<>W messages using relay 8386837 Rococo <> Wococo messages relays 738b756 moved dummy runtime from primitives to relay client 9a42472 copypaste storage_map_final_key to avoid different runtime references/dummy runtimes 52fdf6f impl Parameter for () 80411ba FromBridgedChainEncodedMessageCall<B> -> FromBridgedChainEncodedMessageCall<DecodedCall> 2714baf Chain::ID -> Bridge::THIS_CHAIN_ID+Bridge::BRIDGED_CHAIN_ID c6ef980 MessagesInstance -> BridgedMessagesInstance 03f79ad Allow Root to assume SourceAccount. (#1011) 372d019 Return dispatch_fee_payment from message details RPC (#1014) 604eb1c Relay basic single-bit message dispatch results back to the source chain (#935) bf52fff Use plain source_queue view when selecting nonces for delivery (#1010) fc5cf7d pay dispatch fee at target chain (#911) 1e35477 Bump Substrate to `286d7ce` (#1006) 7ad07b3 Add --only-mandatory-headers mode (#1004) 5351dc9 Messages relayer operating mode (#995) 9bc29a7 Rococo <> Wococo relayer balance guard (#998) bc17341 rename messages_dispatch_weight -> message_details (#996) 95be244 Bump Rococo and Wococo spec versions (#999) c35567b Move ChainWithBalances::NativeBalance -> Chain::Balance (#990) 1bfece1 Fix some nits (#988) 334ea0f Increase pause before starting relays again (#989) 7fb8248 Fix clippy in test code (#993) d60ae50 fix clippy issues (#991) 75ca813 Make sure GRANDPA shares state with RPC. (#987) da2a38a Bump Substrate (#986) 5a9862f Update submit finality proof weight formula (#981) 69df513 Flag for rejecting all outbound messages (#982) 14d0506 Add script to setup bench machine. (#984) e74e8ab Move CI from GitHub Actions to GitLab (#814) c5ca5dd Custom justification verification (#979) 643f10d Always run on-demand headers relay in complex relay (#975) a35b0ef Add JSON type definitions for Rococo<>Wococo bridge (#977) 0eb83f2 Update cargo.deny (#980) e1d1f4c Bump Rococo/Wococo spec_version (#976) deac90d increase pause before starting relays (#974) 68d6d79 Revert to use InspectCmd, bump substrate `6bef4f4` (#966) 66e1508 Avoid hashing headers twice in verify_justification (#973) a31844f Bump `environmental` dependency (#972) 2a4c29a in auto-relays keep trying to connect to nodes until connection is established (#971) 0e767b3 removed stray file (#969) b9545dc Serve multiple lanes with single complex relay instance (#964) 73419f4 Correct type error (#968) bac256f Start finality relay spec-version guards for Rococo <> Wococo finality relays (#965) bfd7037 pass source and target chain ids to account_ownership_proof (#963) 8436073 Upstream changes from Polkadot repo (#961) e58d851 Increase account endowment amount (#960) git-subtree-dir: bridges git-subtree-split: fd24e9849fffafa92402440db9584daab96c36f2

expenses added 2 commits April 3, 2020 12:10

Switch from using the substrate_test_runtime Extrinsic to the polkado…

928697f

…t_test_runtime one

Copy genesismap into test-runtime

439b60c

expenses requested a review from bkchr April 3, 2020 13:19

paritytech-ci added the B2-breaksapi label Apr 3, 2020

bkchr reviewed Apr 3, 2020

View reviewed changes

gavofyork added the A0-please_review Pull request needs code review. label Apr 4, 2020

rphmeier added A3-in_progress Pull request is in progress. No review needed at this stage. and removed A0-please_review Pull request needs code review. labels Apr 4, 2020

expenses added 3 commits April 7, 2020 19:20

Add UncheckedExtrinsics

299aad9

Fix tests :^)

14548bc

Remove unused functions from genesismap

a47e601

expenses requested a review from bkchr April 8, 2020 13:55

expenses marked this pull request as ready for review April 8, 2020 13:55

DRY, clean up

1df43e9

bkchr suggested changes Apr 8, 2020

View reviewed changes

Clean up

50cc5c1

expenses requested a review from bkchr April 9, 2020 20:33

expenses removed the A3-in_progress Pull request is in progress. No review needed at this stage. label Apr 15, 2020

gnunicorn assigned bkchr Apr 17, 2020

bkchr removed their assignment Apr 17, 2020

bkchr suggested changes Apr 17, 2020

View reviewed changes

expenses and others added 3 commits April 20, 2020 09:18

Update service/src/grandpa_support.rs

6696061

Co-Authored-By: Bastian Köcher <bkchr@users.noreply.github.com>

Merge remote-tracking branch 'parity/master' into ashley-test-runtime…

76312fc

…-extrinsic

Fix indentation

a2df14e

expenses requested a review from bkchr April 20, 2020 07:48

bkchr approved these changes Apr 20, 2020

View reviewed changes

runtime/test-runtime/src/genesismap.rs Outdated Show resolved Hide resolved

Update runtime/test-runtime/src/genesismap.rs

0ed611b

bkchr merged commit e843467 into master Apr 21, 2020

bkchr deleted the ashley-test-runtime-extrinsic branch April 21, 2020 10:56

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove usage of substrate-test-runtime. #969

Remove usage of substrate-test-runtime. #969

expenses commented Apr 3, 2020

expenses commented Apr 3, 2020

bkchr Apr 3, 2020

bkchr commented Apr 3, 2020

rphmeier commented Apr 3, 2020 •

edited

Loading

bkchr commented Apr 4, 2020

bkchr left a comment

bkchr Apr 8, 2020

bkchr Apr 8, 2020

bkchr Apr 8, 2020

bkchr Apr 8, 2020

bkchr Apr 8, 2020

expenses commented Apr 15, 2020

bkchr Apr 17, 2020

bkchr Apr 17, 2020

Remove usage of substrate-test-runtime. #969

Remove usage of substrate-test-runtime. #969

Conversation

expenses commented Apr 3, 2020

expenses commented Apr 3, 2020

Choose a reason for hiding this comment

bkchr commented Apr 3, 2020

rphmeier commented Apr 3, 2020 • edited Loading

bkchr commented Apr 4, 2020

bkchr left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

expenses commented Apr 15, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rphmeier commented Apr 3, 2020 •

edited

Loading