Fix serde and decode features without default features #74
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the following feature combinations caused compilation errors:
cargo check --no-default-features --features serde
causedimplementation of `Deserialize` is not general enough
: because by defaultPortableForm::String = &'static str
cargo check --no-default-features --features decode
failed becauseparity-scale-codec
needs thefull
feature to supportString
decoding.The reason we have these features is to support constructing
PortableForm
types for encoding in the substrate runtime, which does not supportString
encoding. See #59 and #35 for more.