Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix serde and decode features without default features #74

Merged
merged 4 commits into from
Mar 4, 2021

Conversation

ascjones
Copy link
Contributor

@ascjones ascjones commented Mar 4, 2021

Previously the following feature combinations caused compilation errors:

cargo check --no-default-features --features serde caused implementation of `Deserialize` is not general enough: because by default PortableForm::String = &'static str

cargo check --no-default-features --features decode failed because parity-scale-codec needs the full feature to support String decoding.

The reason we have these features is to support constructing PortableForm types for encoding in the substrate runtime, which does not support String encoding. See #59 and #35 for more.

@ascjones ascjones merged commit 7deb08c into master Mar 4, 2021
@ascjones ascjones deleted the aj-fix-features branch March 4, 2021 12:41
@ascjones ascjones mentioned this pull request Jun 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants