-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the experimental multiaddr WebRTC support #2722
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Automatically approving tomaka's pull requests. This auto-approval will be removed once more maintainers are active.
twiggy diff reportDifference in .wasm size before and after this pull request.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this doesn't really matter, but would be nice to have same format for webrtc and certhash as https://github.com/multiformats/rust-multiaddr/pull/59/files (WebRTC instead of WebRtc, Certhash instead of CertHash and base64url as default base for certhash)
Sorry, had missed that it was actually a multibase. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Update for multiformats/multiaddr#130 and multiformats/multiaddr#131
Even though I disagree with these protocols, I guess the way forward is to conform.