Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the experimental multiaddr WebRTC support #2722

Merged
merged 5 commits into from
Sep 8, 2022

Conversation

tomaka
Copy link
Contributor

@tomaka tomaka commented Sep 7, 2022

Update for multiformats/multiaddr#130 and multiformats/multiaddr#131

Even though I disagree with these protocols, I guess the way forward is to conform.

@tomaka tomaka requested a review from melekes September 7, 2022 12:22
Copy link
Contributor

@mergify mergify bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automatically approving tomaka's pull requests. This auto-approval will be removed once more maintainers are active.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 7, 2022

twiggy diff report

Difference in .wasm size before and after this pull request.


 Delta Bytes │ Item
─────────────┼────────────────────────────────────────────────────────────────────────────────────────────────────────────────
      -46502 ┊ smoldot::executor::host::ReadyToRun::run_once::h5f7d441840040e5a
      +46502 ┊ smoldot::executor::host::ReadyToRun::run_once::h8b706f35b037c8f7
      -44761 ┊ smoldot::json_rpc::methods::MethodCall::from_defs::h194d0a56220920c9
      +44761 ┊ smoldot::json_rpc::methods::MethodCall::from_defs::h9776f25aa162aae7
      +15698 ┊ smoldot_light::sync_service::parachain::start_parachain::{{closure}}::h8d9eb73f32b52598
      -15698 ┊ smoldot_light::sync_service::parachain::start_parachain::{{closure}}::hbfa56f3a4437efce
      +12063 ┊ <core::future::from_generator::GenFuture<T> as core::future::future::Future>::poll::h617b4c62ea7d82f5
      -12063 ┊ <core::future::from_generator::GenFuture<T> as core::future::future::Future>::poll::h8cd65bd2de0b3d38
      +11257 ┊ smoldot::network::service::ChainNetwork<TNow>::next_event::h0a88e366f2a51540
      -11257 ┊ smoldot::network::service::ChainNetwork<TNow>::next_event::h7d84fe1305f48c3a
      +11234 ┊ smoldot_light::Client<TPlat,TChain>::add_chain::h83ddfdb48fcd3197
      -11234 ┊ smoldot_light::Client<TPlat,TChain>::add_chain::hf6a948d78b4fafda
      +10784 ┊ <core::future::from_generator::GenFuture<T> as core::future::future::Future>::poll::h520e1e7cef22679f
      -10784 ┊ <core::future::from_generator::GenFuture<T> as core::future::future::Future>::poll::hb72ccf800321b62b
      +10402 ┊ <parity_wasm::elements::ops::Instruction as parity_wasm::elements::Deserialize>::deserialize::h9602291a927ed5b8
      -10402 ┊ <parity_wasm::elements::ops::Instruction as parity_wasm::elements::Deserialize>::deserialize::hdc15c2177233dbf3
      -10394 ┊ smoldot::json_rpc::methods::Response::to_json_response::h39f86d941db56fd1
      +10394 ┊ smoldot::json_rpc::methods::Response::to_json_response::hae08e822be120b76
      +10322 ┊ smoldot::sync::warp_sync::BuildChainInformation<TSrc,TRq>::build::h82cf545aa85e37fd
      -10322 ┊ smoldot::sync::warp_sync::BuildChainInformation<TSrc,TRq>::build::h8efbaa2bed96a956
      +15472 ┊ ... and 29520 more.
      +18079 ┊ Σ [29540 Total Rows]

Copy link
Contributor

@melekes melekes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this doesn't really matter, but would be nice to have same format for webrtc and certhash as https://github.com/multiformats/rust-multiaddr/pull/59/files (WebRTC instead of WebRtc, Certhash instead of CertHash and base64url as default base for certhash)

src/libp2p/multiaddr.rs Outdated Show resolved Hide resolved
src/libp2p/multiaddr.rs Outdated Show resolved Hide resolved
src/libp2p/multiaddr.rs Outdated Show resolved Hide resolved
src/libp2p/multiaddr.rs Outdated Show resolved Hide resolved
@tomaka
Copy link
Contributor Author

tomaka commented Sep 7, 2022

Sorry, had missed that it was actually a multibase.

Copy link
Contributor

@melekes melekes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@tomaka tomaka added the automerge Automatically merge pull request as soon as possible label Sep 8, 2022
@mergify mergify bot merged commit 072b7a9 into paritytech:main Sep 8, 2022
@tomaka tomaka deleted the webrtc-multiaddr-update branch September 8, 2022 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Automatically merge pull request as soon as possible
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants