Remove implementation of Randomness for () (#6959)

paritytech · Aug 26, 2020 · 8e2319f · 8e2319f
1 parent 0a391e4
commit 8e2319f
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/frame/society/src/mock.rs b/frame/society/src/mock.rs
@@ -20,7 +20,8 @@
 use super::*;
 
 use frame_support::{
-	impl_outer_origin, parameter_types, ord_parameter_types, traits::{OnInitialize, OnFinalize}
+	impl_outer_origin, parameter_types, ord_parameter_types,
+	traits::{OnInitialize, OnFinalize, TestRandomness},
 };
 use sp_core::H256;
 use sp_runtime::{
@@ -99,7 +100,7 @@ impl pallet_balances::Trait for Test {
 impl Trait for Test {
 	type Event = ();
 	type Currency = pallet_balances::Module<Self>;
-	type Randomness = ();
+	type Randomness = TestRandomness;
 	type CandidateDeposit = CandidateDeposit;
 	type WrongSideDeduction = WrongSideDeduction;
 	type MaxStrikes = MaxStrikes;

diff --git a/frame/support/src/traits.rs b/frame/support/src/traits.rs
@@ -1345,7 +1345,10 @@ pub trait Randomness<Output> {
 	}
 }
 
-impl<Output: Decode + Default> Randomness<Output> for () {
+/// Provides an implementation of [`Randomness`] that should only be used in tests!
+pub struct TestRandomness;
+
+impl<Output: Decode + Default> Randomness<Output> for TestRandomness {
 	fn random(subject: &[u8]) -> Output {
 		Output::decode(&mut TrailingZeroInput::new(subject)).unwrap_or_default()
 	}