Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Migrate Aura authorship-detection to Pre-runtime digests #2986

Closed
rphmeier opened this issue Jul 1, 2019 · 2 comments · Fixed by #3293
Closed

Migrate Aura authorship-detection to Pre-runtime digests #2986

rphmeier opened this issue Jul 1, 2019 · 2 comments · Fixed by #3293
Assignees
@Demi-Marie
Labels
J0-enhancement An additional feature request.
Milestone
Ideas

Comments

@rphmeier
Copy link
Contributor

rphmeier commented Jul 1, 2019

The inherent-based approach used before is now obsolete. See #2929 as an example of how to use PreRuntime digests in the runtime to compute authorship info.

This should be accompanied with a FindAuthor<u32> implementation.
@rphmeier rphmeier added the J0-enhancement An additional feature request. label Jul 1, 2019
@rphmeier rphmeier added this to the As-and-when milestone Jul 1, 2019
@Demi-Marie
Copy link
Contributor

Are inherents obsolete at this point?

@rphmeier
Copy link
Contributor Author

rphmeier commented Jul 2, 2019 •
edited
Loading

@demimarie-parity for this use-case. Not for others. Specifically because this is information that has to live in the header anyway, so putting it in an inherent means cross-checking and duplication

@gui1117 gui1117 mentioned this issue Jul 26, 2019
Closed
@cmichi cmichi mentioned this issue Jul 27, 2019
Closed
4 tasks
@Demi-Marie Demi-Marie self-assigned this Aug 1, 2019
@andresilva andresilva mentioned this issue Aug 2, 2019
Merged
@shawntabrizi shawntabrizi mentioned this issue Mar 15, 2021
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Demi-Marie Demi-Marie

Labels
J0-enhancement An additional feature request.
Projects
None yet
Milestone
Ideas
Development

Successfully merging a pull request may close this issue.

node: use BABE predigest data to find authorship paritytech/substrate
2 participants
@rphmeier @Demi-Marie