This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Add srml/im-online integrations #3223
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmichi
added
the
A3-in_progress
This was referenced Jul 27, 2019
Closed
cmichi
force-pushed
the
cmichi-heartbeat-integrations
branch
2 times, most recently
from
777dbde
to
063bf25
Compare
cmichi
force-pushed
the
cmichi-heartbeat-integrations
branch
from
063bf25
to
a3857ab
Compare
niklasad1
reviewed
Jul 27, 2019
niklasad1
reviewed
Jul 29, 2019
Co-Authored-By: Niklas Adolfsson <niklasadolfsson1@gmail.com>
|
This should all be sorted in #3296 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #2719.
This PR tries to achieve two things:
srml/im-onlinewere not online in the session which just ended should be disabled.Tests will follow in a follow-up PR, once the behavior/API is set.
ToDos
ImOnlineConfigdon't need to be configurable, they should both just be0by default.srml/im-onlineversion in Polkadot (here's the PR for themasterversion of this module, Integrate srml/im-online polkadot#342, needs to be updated once this PR is merged).Current Status
I checked two of the ToDos, since a review hasn't been done yet this is to be taken with reservation though.
The automatically-mark-online feature is implemented in this PR, but the
note_author()hooks will only work properly after #2986 has implementedauthorship::Traitfor the runtime (same goes for e.g. thenote_author()hooks which slashing has implemented).The tests run besides this one, which is deadlocking:
I suspect because of something to do with authorship.