Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Disable the Kademlia discovery when --reserved-only is passed #6031

Closed
tomaka opened this issue May 14, 2020 · 3 comments · Fixed by #7999
Closed

Disable the Kademlia discovery when --reserved-only is passed #6031

tomaka opened this issue May 14, 2020 · 3 comments · Fixed by #7999
Labels
I4-annoyance The client behaves within expectations, however this “expected behaviour” itself is at issue.

Comments

@tomaka
Copy link
Contributor

tomaka commented May 14, 2020 •
edited
Loading

The idea behind sentry nodes is that their validators should be only ever be connected to them.

At the moment, validators still perform Kademlia requests, both for random discovery purposes and for the authority-discovery system.

cc @mxinden

This is low priority. This issue exists in order to not forget to do that.
@tomaka tomaka added the I4-annoyance The client behaves within expectations, however this “expected behaviour” itself is at issue. label May 14, 2020
@tomaka
Copy link
Contributor Author

tomaka commented Jun 5, 2020

Depends on #6264

@mxinden mxinden mentioned this issue Jun 15, 2020
Closed
@tomaka tomaka mentioned this issue Aug 24, 2020
Closed
@tomaka
Copy link
Contributor Author

tomaka commented Aug 24, 2020

This issue was originally opened because validator nodes should only ever be connected to sentry nodes, and not open third-party connections. Despite sentry nodes being deprecated, we should still do this change.

@tomaka tomaka changed the title Disable the Kademlia discovery and authority discovery Kademlia queries when --reserved-only is passed Disable the Kademlia discovery when --reserved-only is passed Aug 25, 2020
@subtly
Copy link

subtly commented Oct 31, 2020

@tomaka Where in the codebase would I look into fixing this?

@tomaka tomaka mentioned this issue Jan 28, 2021
Merged
@ghost ghost closed this as completed in #7999 Feb 2, 2021
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
I4-annoyance The client behaves within expectations, however this “expected behaviour” itself is at issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Disable Kademlia random walk when --reserved-nodes is passed tomaka/polkadot
2 participants
@tomaka @subtly