Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Authority-discovery should be performed only by sentries #6264

Closed
Tracked by #989
tomaka opened this issue Jun 5, 2020 · 6 comments
Closed
Tracked by #989

Authority-discovery should be performed only by sentries #6264

tomaka opened this issue Jun 5, 2020 · 6 comments
Labels
I4-annoyance The client behaves within expectations, however this “expected behaviour” itself is at issue.

Comments

@tomaka
Copy link
Contributor

tomaka commented Jun 5, 2020

At the moment, validators publish the authority-discovery-related DHT records themselves. This is necessary because these records are signed with a key known to the validator only.

However, this reveals the validator's IP address.

Instead, the validator should send this signed record to its sentry nodes, and it's the sentry nodes that should perform the publication.

@rphmeier rphmeier added the I4-annoyance The client behaves within expectations, however this “expected behaviour” itself is at issue. label Jun 6, 2020
@tomaka
Copy link
Contributor Author

tomaka commented Jul 24, 2020

As long as this isn't tackled, sentry nodes don't provide much protection.
An attacker can generate a network identity close to a certain validator ID, connect to the network, and the validator will sooner or later establish a TCP connection to that attacker.

@burdges
Copy link

burdges commented Jul 24, 2020

Yes. sentry nodes would imply the validator never even opens connections with anybody besides their sentries.

@tomaka
Copy link
Contributor Author

tomaka commented Jul 24, 2020

Additionally, the validator should not perform the get_value calls either. Instead, it's the sentry that would have to do it and pass the results to its validator.

@tomaka
Copy link
Contributor Author

tomaka commented Jul 29, 2020

I believe that the solution is to add two small request-reponse protocols:

  • One for sentries to periodically query the records to publish on the DHT.
  • One for sentries to periodically (every 10mn) report the list of validators that they have discovered through the DHT.

It should be quite easy to do that after #6634 is merged.

@tomaka
Copy link
Contributor Author

tomaka commented Aug 4, 2020

Would be obsolete after #6762

@tomaka
Copy link
Contributor Author

tomaka commented Aug 24, 2020

Closing as obsolete.

@tomaka tomaka closed this as completed Aug 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
I4-annoyance The client behaves within expectations, however this “expected behaviour” itself is at issue.
Projects
None yet
Development

No branches or pull requests

3 participants