Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Lock-free state cache #9320

Closed
arkpar opened this issue Jul 10, 2021 · 0 comments · Fixed by #11407
Closed

Lock-free state cache #9320

arkpar opened this issue Jul 10, 2021 · 0 comments · Fixed by #11407
Labels
I9-optimisation An enhancement to provide better overall performance in terms of time-to-completion for a task.

Comments

@arkpar
Copy link
Member

arkpar commented Jul 10, 2021

State cache is currently using LinkedHashMap which is not ideal for concurrent access. Each get requires taking a write lock for the cache refresh. This makes parallel requests for a recent state data inefficient.

LinkedHashMap should be replaced with a data structure that is either lock-free or implements copy-on-write semantics. E.g. ARCache

Related: #9312
@arkpar arkpar added the I9-optimisation An enhancement to provide better overall performance in terms of time-to-completion for a task. label Jul 10, 2021
@arkpar arkpar mentioned this issue Jul 10, 2021
Merged
@bkchr bkchr mentioned this issue May 12, 2022
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
I9-optimisation An enhancement to provide better overall performance in terms of time-to-completion for a task.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Introduce trie level cache and remove state cache paritytech/substrate
1 participant
@arkpar