Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Reduce shared state cache contention #9321

Merged
1 commit merged into from
Jul 14, 2021
Merged

Reduce shared state cache contention #9321

1 commit merged into from
Jul 14, 2021

Conversation

arkpar
Copy link
Member

@arkpar arkpar commented Jul 10, 2021

Closes #9312
This only helps when most requests are cache misses. I.e. when requesting historical data.
Cache hits still require write access to a shared lock to update the LRU map. See #9320

@arkpar arkpar added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit labels Jul 10, 2021
Copy link
Contributor

@cheme cheme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@gui1117 gui1117 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not familiar with this part of the codebase but change looks good

@arkpar
Copy link
Member Author

arkpar commented Jul 14, 2021

bot merge

@ghost
Copy link

ghost commented Jul 14, 2021

Trying merge.

@ghost ghost merged commit d66c472 into master Jul 14, 2021
@ghost ghost deleted the a-better-state-cache branch July 14, 2021 11:29
jordy25519 pushed a commit to cennznet/substrate that referenced this pull request Sep 17, 2021
jordy25519 pushed a commit to cennznet/substrate that referenced this pull request Sep 19, 2021
jordy25519 pushed a commit to cennznet/substrate that referenced this pull request Sep 20, 2021
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

StorageCache lock is slowing down RPC requests
3 participants